From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbdJXJa3 (ORCPT ); Tue, 24 Oct 2017 05:30:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58108 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdJXJaR (ORCPT ); Tue, 24 Oct 2017 05:30:17 -0400 Date: Tue, 24 Oct 2017 18:30:14 +0900 (KST) Message-Id: <20171024.183014.399601216375547757.davem@davemloft.net> To: garsilva@embeddedor.com Cc: ubraun@linux.vnet.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: smc_close: mark expected switch fall-through From: David Miller In-Reply-To: <20171022013530.GA15859@embeddedor.com> References: <20171021202100.Horde.z-7P99HVhWm0m3hXj5cOjur@gator4166.hostgator.com> <20171022013530.GA15859@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Oct 2017 02:30:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Sat, 21 Oct 2017 20:35:30 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I placed the "fall through" comment > on its own line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Move the "fall through" comment on its own line > above the rest of the sentence. Applied.