From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbdJXBjx (ORCPT ); Mon, 23 Oct 2017 21:39:53 -0400 Received: from omzsmtpe02.verizonbusiness.com ([199.249.25.209]:50466 "EHLO omzsmtpe02.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbdJXBjv (ORCPT ); Mon, 23 Oct 2017 21:39:51 -0400 From: "Levin, Alexander (Sasha Levin)" X-Host: mariner.tdc.vzwcorp.com To: Boris Ostrovsky CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Jan Beulich Subject: Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf() Thread-Topic: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf() Thread-Index: AQHTTGjjzZ0BrPHCy0Ken/0TkJdKHw== Date: Tue, 24 Oct 2017 01:39:09 +0000 Message-ID: <20171024013859.2lmqy6zigft2m3mf@sasha-lappy> References: <20171007223636.24797-1-alexander.levin@verizon.com> <20171007223636.24797-31-alexander.levin@verizon.com> <0c5dfb50-0dc4-7df5-ae5c-1998781289dd@oracle.com> In-Reply-To: <0c5dfb50-0dc4-7df5-ae5c-1998781289dd@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: <60033B9634D6264DAD0CFD5AF584DDCB@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9O1duHx015549 On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote: >On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote: >> From: Jan Beulich >> >> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] >> >> A negative return value indicates an error; in fact the function at >> present won't ever return zero. >> >> Signed-off-by: Jan Beulich >> Reviewed-by: Juergen Gross >> Signed-off-by: Boris Ostrovsky >> Signed-off-by: Sasha Levin > >This patch will cause a warning to be printed. Please pull commit >4e93b64 ("xen: don't print error message in case of missing Xenstore >entry") as well. Added, thanks Boris. -- Thanks, Sasha