From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdJXDZl (ORCPT ); Mon, 23 Oct 2017 23:25:41 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34804 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdJXDZi (ORCPT ); Mon, 23 Oct 2017 23:25:38 -0400 Date: Tue, 24 Oct 2017 11:25:08 +0800 From: Herbert Xu To: "Gustavo A. R. Silva" Cc: Steffen Klassert , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG Message-ID: <20171024032508.GC28462@gondor.apana.org.au> References: <20171023181857.GA25379@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171023181857.GA25379@embeddedor.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 01:18:57PM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva I think this patch is terrible. Why on earth is Coccinelle even warning about this? If anything we should be converting these constructs to not use BUG. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt