From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751025AbdJXEb3 (ORCPT ); Tue, 24 Oct 2017 00:31:29 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34860 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbdJXEb1 (ORCPT ); Tue, 24 Oct 2017 00:31:27 -0400 Date: Tue, 24 Oct 2017 12:30:51 +0800 From: Herbert Xu To: Alexei Starovoitov Cc: "Gustavo A. R. Silva" , Steffen Klassert , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG Message-ID: <20171024043051.GA29883@gondor.apana.org.au> References: <20171023181857.GA25379@embeddedor.com> <20171024032508.GC28462@gondor.apana.org.au> <20171023225043.Horde.R0FvJkHEmPPjnRNzKMOrPb3@gator4166.hostgator.com> <20171024035320.GA29795@gondor.apana.org.au> <20171024040144.bf2cvq7p6zwg2e5k@ast-mbp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024040144.bf2cvq7p6zwg2e5k@ast-mbp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 09:01:46PM -0700, Alexei Starovoitov wrote: > > fwiw I had the same argument earlier: > https://lkml.org/lkml/2017/10/9/1139 Fair point on eliminating a branch. But I'd prefer something like bool cond; cond = code_that_does_something(); BUG_ON(cond); rather than just BUG_ON(code_that_does_something()); But maybe it's just me. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt