From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbdJXIfX (ORCPT ); Tue, 24 Oct 2017 04:35:23 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36252 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdJXIfS (ORCPT ); Tue, 24 Oct 2017 04:35:18 -0400 Date: Tue, 24 Oct 2017 10:35:04 +0200 From: Peter Zijlstra To: Tejun Heo Cc: Li Zefan , Johannes Weiner , Ingo Molnar , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat Message-ID: <20171024083504.GM3165@worktop.lehotels.local> References: <20171023231827.GA8598@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171023231827.GA8598@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote: > The basic cpu stat is currently shown with "cpu." prefix in > cgroup.stat, and the same information is duplicated in cpu.stat when > cpu controller is enabled. This is ugly and not very scalable as we > want to expand the coverage of stat information which is always > available. > > This patch makes cgroup core always create "cpu.stat" file and show > the basic cpu stat there and calls the cpu controller to show the > extra stats when enabled. This ensures that the same information > isn't presented in multiple places and makes future expansion of basic > stats easier. > > Signed-off-by: Tejun Heo > --- > Hello, > > The more I think about showing cpu stat in cgroup.stat, the uglier it > seems. I've not been paying much attention to this, could you elaborate on the problems there? > This patch flips it so that "cpu.stat" is always available > with basic cpu stat instead. It only changes the presentation and > changes to the scheduler code is minimal. Will route with the other > cpu controller changes through cgroup/for-4.15 unless there are > objections. And this is -v2 only? I'm a little lost on how all that connects.