From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932209AbdJXJVj (ORCPT ); Tue, 24 Oct 2017 05:21:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:41818 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbdJXJVe (ORCPT ); Tue, 24 Oct 2017 05:21:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="1234520184" Date: Tue, 24 Oct 2017 12:21:27 +0300 From: Mika Westerberg To: Bin Meng Cc: Arnd Bergmann , Cyrille Pitchen , linux-mtd , linux-kernel , Stefan Roese Subject: Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH Message-ID: <20171024092127.GB29656@lahna.fi.intel.com> References: <1508828379-3479-1-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508828379-3479-1-git-send-email-bmeng.cn@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote: > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Enforce dependency on PCI > > drivers/mtd/spi-nor/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index f26aaa6..abf453a 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI > > config SPI_INTEL_SPI_PLATFORM > tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT > - depends on X86 > + depends on X86 && PCI It is kind of weird to depend on PCI if we want to enable *platform* driver but whatever. I would still prefer to have dependency for LPC_ICH instead. No strong feelings though - as long as it builds and works fine :-) > select SPI_INTEL_SPI > + select LPC_ICH > help > This enables platform support for the Intel PCH/PCU SPI > controller in master mode. This controller is present in modern > -- > 2.7.4