From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@armlinux.org.uk>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@gmail.com>
Subject: [PATCH v3 2/2] arm: topology: add missing of_node_put() for cpu device node
Date: Tue, 24 Oct 2017 11:27:18 +0100 [thread overview]
Message-ID: <20171024102718.16113-3-dietmar.eggemann@arm.com> (raw)
In-Reply-To: <20171024102718.16113-1-dietmar.eggemann@arm.com>
This patch adds the missing of_node_put() for of_find_node_by_path() and
of_get_cpu_node() in parse_dt_topology().
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Juri Lelli <juri.lelli@gmail.com>
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
---
arch/arm/kernel/topology.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index 15cc131ae387..81ec42333489 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c
@@ -41,6 +41,7 @@ static void __init parse_dt_topology(void)
pr_err("No CPU information found in DT\n");
return;
}
+ of_node_put(cn);
for_each_possible_cpu(cpu) {
/* too early to use cpu->of_node */
@@ -50,8 +51,8 @@ static void __init parse_dt_topology(void)
continue;
}
- if (topology_parse_cpu_capacity(cn, cpu))
- of_node_put(cn);
+ topology_parse_cpu_capacity(cn, cpu);
+ of_node_put(cn);
}
topology_normalize_cpu_scale();
--
2.11.0
next prev parent reply other threads:[~2017-10-24 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 10:27 [PATCH v3 0/2] arm: remove cpu_efficiency Dietmar Eggemann
2017-10-24 10:27 ` [PATCH v3 1/2] arm: topology: " Dietmar Eggemann
2017-10-24 10:27 ` Dietmar Eggemann [this message]
2017-10-24 10:52 ` [PATCH v3 0/2] arm: " Russell King - ARM Linux
2017-10-24 14:31 ` Dietmar Eggemann
2017-11-24 11:57 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024102718.16113-3-dietmar.eggemann@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®