From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdJXLxx (ORCPT ); Tue, 24 Oct 2017 07:53:53 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:58780 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825AbdJXLxu (ORCPT ); Tue, 24 Oct 2017 07:53:50 -0400 Date: Tue, 24 Oct 2017 12:53:38 +0100 From: Russell King - ARM Linux To: Maninder Singh Cc: mingo@kernel.org, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pankaj.m@samsung.com, a.sahrawat@samsung.com, Vaneet Narang Subject: Re: [PATCH 1/1] arm/stacktrace: stop unwinding after an invalid address. Message-ID: <20171024115338.GF20805@n2100.armlinux.org.uk> References: <1508845602-33508-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508845602-33508-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 05:16:42PM +0530, Maninder Singh wrote: > This patch stops unwinding backtrace in case of below 2 cases. > > (Issue observed while porting stackdepot on ARM, duplicate > entries created in stackdepot > reference patch for workaround in stackdepot:- > https://lkml.org/lkml/2017/10/11/353 > ). > > 1. If address belongs to irq/exception code, ignore it. > save_stack+0x40/0xec > __set_page_owner+0x2c/0x64 > .... > .... > __handle_domain_irq+0x9c/0x130 > gic_handle_irq+0x40/0x80 > __irq_usr+0x4c/0x60 > 0xb6507818 > ^^^^^^^ However, we _do_ want to trace through an IRQ taken in SVC mode, but you completely remove all that code. So, not taking this patch, sorry. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up