From: Dan Carpenter <dan.carpenter@oracle.com>
To: Garry Hurley <garry.hurley.jr@gmail.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
Jani Nikula <jani.nikula@linux.intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()
Date: Tue, 24 Oct 2017 17:26:15 +0300 [thread overview]
Message-ID: <20171024142615.t3y5atz6nulkq55h@mwanda> (raw)
In-Reply-To: <1A433E6A-DE06-4407-9E33-3CBBA4ADF01B@gmail.com>
The point of unwind code is to undo what was done earlier. If a
function allocates a list of things, using standard unwind style makes
it simpler, safer and more readable.
This isn't the case here. Instead of making the code more readable,
we're making it more convoluted. It's just that two out of three error
messages happened to be the same and Markus wants to save a bit of
memory by using the same string. The memory savings is not so big that
it's worth making the code less readable.
regards,
dan carpenter
next prev parent reply other threads:[~2017-10-24 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 12:25 [PATCH] " SF Markus Elfring
2017-10-24 12:52 ` Jani Nikula
2017-10-24 13:17 ` SF Markus Elfring
2017-10-24 13:54 ` Garry Hurley
2017-10-24 14:26 ` Dan Carpenter [this message]
2017-10-24 14:40 ` SF Markus Elfring
2017-10-24 14:42 ` Joe Perches
2017-10-24 14:51 ` SF Markus Elfring
2017-10-24 14:56 ` Joe Perches
2017-10-24 15:01 ` SF Markus Elfring
2017-10-24 15:14 ` Daniele Nicolodi
2017-10-24 18:56 ` [PATCH] " Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024142615.t3y5atz6nulkq55h@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=garry.hurley.jr@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®