From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752169AbdJXNMI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 09:12:08 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:55706 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752083AbdJXNME (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 09:12:04 -0400
X-Google-Smtp-Source: ABhQp+SrDvOi+tlBjN1HYN1gfTxeSztz4lI/kb0eV+SuiKYdnlRcOBV8Is91TDTM0gVQ3YGIK+n2ig==
Date: Tue, 24 Oct 2017 15:11:52 +0200
From: Stephen Hemminger <stephen@networkplumber.org>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "Stahl, Manuel" <manuel.stahl@iis-extern.fraunhofer.de>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "hjk@linutronix.de" <hjk@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "sojkam1@fel.cvut.cz" <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers
Message-ID: <20171024151152.6c156c9a@shemminger-XPS-13-9360>
In-Reply-To: <20171020125044.GA8634@kroah.com>
References: <1507296707.2915.14.camel@iis-extern.fraunhofer.de>
        <1507296804.2915.16.camel@iis-extern.fraunhofer.de>
        <20171006134550.GA1626@kroah.com>
        <1507297826.2915.18.camel@iis-extern.fraunhofer.de>
        <20171006075700.587a5e22@xeon-e3>
        <20171020125044.GA8634@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9ODCDk9028388

On Fri, 20 Oct 2017 14:50:44 +0200
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> wrote:

> On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote:
> > On Fri, 6 Oct 2017 13:50:44 +0000
> > "Stahl, Manuel" <manuel.stahl@iis-extern.fraunhofer.de> wrote:
> >   
> > > MSI(X) interrupts are not shared between devices. So when available
> > > those should be preferred over legacy interrupts.
> > > 
> > > Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
> > > ---
> > >  drivers/uio/uio_pci_dmem_genirq.c | 27 ++++++++++++++++++++-------
> > >  drivers/uio/uio_pci_generic.c     | 24 ++++++++++++++++++------
> > >  2 files changed, 38 insertions(+), 13 deletions(-)  
> > 
> > The last time I tried to do MSI-X with pci-generic it got rejected
> > by the maintainer.  
> 
> Hm, yeah, this would break users today that do not have msi-x, right?
> 
> Not good, Manuel, how well did you test this?
> 
> thanks,
> 
> greg k-h

Look at https://patchwork.kernel.org/patch/7303021/

The objection was more that UIO developers did not like that
UIO was (already) being used for DMA without IOMMU, and MSI-x has DMA because
of vector table.