From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751559AbdJXPiV (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 11:38:21 -0400
Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:14188 "EHLO
        smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751267AbdJXPiS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 11:38:18 -0400
X-IronPort-AV: E=Sophos;i="5.43,428,1503360000"; 
   d="scan'208";a="569511125"
Date: Tue, 24 Oct 2017 08:37:56 -0700
From: Eduardo Valentin <eduval@amazon.com>
To: Peter Zijlstra <peterz@infradead.org>
CC: Eduardo Valentin <eduval@amazon.com>,
        Paolo Bonzini <pbonzini@redhat.com>, <rkrcmar@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        <x86@kernel.org>, Waiman Long <longman@redhat.com>,
        <kvm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "Jan H . Schoenherr" <jschoenh@amazon.de>,
        Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCH 1/1] locking/qspinlock/x86: Avoid test-and-set when
 PV_DEDICATED is set
Message-ID: <20171024153756.GA5007@u40b0340c692b58f6553c.ant.amazon.com>
References: <1508805867-14583-1-git-send-email-eduval@amazon.com>
 <20171024081345.GK3165@worktop.lehotels.local>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171024081345.GK3165@worktop.lehotels.local>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Peter,
On Tue, Oct 24, 2017 at 10:13:45AM +0200, Peter Zijlstra wrote:
> On Mon, Oct 23, 2017 at 05:44:27PM -0700, Eduardo Valentin wrote:
> > @@ -46,6 +48,8 @@ static inline bool virt_spin_lock(struct qspinlock *lock)
> >  	if (!static_cpu_has(X86_FEATURE_HYPERVISOR))
> >  		return false;
> >  
> > +	if (kvm_para_has_feature(KVM_FEATURE_PV_DEDICATED))
> > +		return false;
> >  	/*
> >  	 * On hypervisors without PARAVIRT_SPINLOCKS support we fall
> >  	 * back to a Test-and-Set spinlock, because fair locks have
> 
> This does not apply. Much has been changed here recently.
> 

 I checked against Linus master branch before sending. Which tree/branch are you referring to / should I based this?

-- 
All the best,
Eduardo Valentin