From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdJXTHX (ORCPT ); Tue, 24 Oct 2017 15:07:23 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:44692 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdJXTHV (ORCPT ); Tue, 24 Oct 2017 15:07:21 -0400 X-Google-Smtp-Source: ABhQp+Q8CENoCfdKF0O43/yWTc97sRuUBKgSOEkyUJ8MU6LRuTYvl/xJ9ZpCwVAH2kfQYSqJhB5SEQ== Date: Tue, 24 Oct 2017 14:07:19 -0500 From: Rob Herring To: Andrey Smirnov Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, cphealy@gmail.com, Lucas Stach , Nikita Yushchenko , Lee Jones , Greg Kroah-Hartman , Pavel Machek , Andy Shevchenko , Guenter Roeck , Johan Hovold , Mark Rutland Subject: Re: [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for RAVE SP watchdog driver Message-ID: <20171024190719.w4wy3omflkugkocg@rob-hp-laptop> References: <20171018170136.12347-1-andrew.smirnov@gmail.com> <20171018170136.12347-6-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171018170136.12347-6-andrew.smirnov@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 10:01:36AM -0700, Andrey Smirnov wrote: Commit msg? > Cc: linux-kernel@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-watchdog@vger.kernel.org > Cc: cphealy@gmail.com > Cc: Lucas Stach > Cc: Nikita Yushchenko > Cc: Lee Jones > Cc: Greg Kroah-Hartman > Cc: Pavel Machek > Cc: Andy Shevchenko > Cc: Guenter Roeck > Cc: Rob Herring > Cc: Johan Hovold > Cc: Mark Rutland > Signed-off-by: Nikita Yushchenko > Signed-off-by: Andrey Smirnov > --- > Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt b/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt > new file mode 100644 > index 000000000000..f242c3eed0dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt > @@ -0,0 +1,10 @@ > +Zodiac Inflight Innovations RAVE Supervisory Processor Watchdog > + > +Required properties: > + > + - compatible: Should be "zii,rave-sp-watchdog" > + Must be a child of ? defined in ? > +Optional properties: > + > + - Two byte nvmem cell "wdt_timeout", specified as per > + Documentation/devicetree/bindings/nvmem/nvmem.txt prop name: definition... is the normal format. Also, don't use '_' in property names. Rob