From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751921AbdJYArI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 20:47:08 -0400
Received: from foss.arm.com ([217.140.101.70]:60688 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751670AbdJYArH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 20:47:07 -0400
Date: Tue, 24 Oct 2017 19:47:05 -0500
From: Kim Phillips <kim.phillips@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        <linux-arm-kernel@lists.infradead.org>, <marc.zyngier@arm.com>,
        <mark.rutland@arm.com>, <tglx@linutronix.de>, <peterz@infradead.org>,
        <alexander.shishkin@linux.intel.com>, <robh@kernel.org>,
        <suzuki.poulose@arm.com>, <pawel.moll@arm.com>,
        <mathieu.poirier@linaro.org>, <mingo@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] perf tool: stat: say more about why event is not
 supported by the kernel
Message-Id: <20171024194705.31c1af9508fa0c3195ab359e@arm.com>
In-Reply-To: <20171024133530.GB13445@arm.com>
References: <20171024030408.d29c81d6134bf63df18ae618@arm.com>
        <20171024133530.GB13445@arm.com>
Organization: Arm
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 24 Oct 2017 14:35:30 +0100
Will Deacon <will.deacon@arm.com> wrote:

> On Tue, Oct 24, 2017 at 03:04:08AM -0500, Kim Phillips wrote:
> > +++ b/tools/perf/builtin-stat.c
> > @@ -625,9 +625,13 @@ static int __run_perf_stat(int argc, const char **argv)
> >  			if (errno == EINVAL || errno == ENOSYS ||
> >  			    errno == ENOENT || errno == EOPNOTSUPP ||
> >  			    errno == ENXIO) {
> > -				if (verbose > 0)
> > +				if (verbose > 0) {
> >  					ui__warning("%s event is not supported by the kernel.\n",
> >  						    perf_evsel__name(counter));
> > +					perf_evsel__open_strerror(counter, &target,
> > +								  errno, msg, sizeof(msg));
> > +					ui__error("%s\n", msg);
> > +				}
> 
> Hmm, perf_evsel__open_strerror can already get called a few lines later, so

That's in the case when perf decides to fully abort, whereas this
change allows users to know why perf stat output lists '<not
supported>' instead of having a count figure next to the event requested:

BEFORE THIS SERIES:

# ./oldperf stat -v -e ccn/cycles/ku sleep 1
Warning:
ccn/cycles/ku event is not supported by the kernel.
failed to read counter ccn/cycles/ku

 Performance counter stats for 'system wide':

   <not supported>      ccn/cycles/ku                                               

       1.002756731 seconds time elapsed

AFTER THIS SERIES (amended to show only strerror_arch output):

The tool itself tells the user the event can't exclude execution
levels, rather than the user having to refer to dmesg:

# ./newperf stat -v -e ccn/cycles/ku sleep 1
Warning:
ccn/cycles/ku: Can't exclude execution levels!
failed to read counter ccn/cycles/ku

 Performance counter stats for 'system wide':

   <not supported>      ccn/cycles/ku                                               

       1.002935620 seconds time elapsed

> I don't think this change is right. It looks like the intention here is that
> we can push ahead skipping unsupported events unless they are the leader of
> a populated group. If this isn't working as intended, then it looks like we
> need a helper to identify unsupported events instead.

I could be wrong, but I think it's working as intended:  this patch
just adds more user-visible resolution into the event opening errors.

Kim