From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751931AbdJYBLL (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 21:11:11 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:60858 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751758AbdJYBLJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 21:11:09 -0400
Date: Tue, 24 Oct 2017 20:11:08 -0500
From: Kim Phillips <kim.phillips@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        <linux-arm-kernel@lists.infradead.org>, <marc.zyngier@arm.com>,
        <mark.rutland@arm.com>, <tglx@linutronix.de>, <peterz@infradead.org>,
        <alexander.shishkin@linux.intel.com>, <robh@kernel.org>,
        <suzuki.poulose@arm.com>, <pawel.moll@arm.com>,
        <mathieu.poirier@linaro.org>, <mingo@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf
 open strerror capability
Message-Id: <20171024201108.0fcc0118cf0c7ccd835c63d6@arm.com>
In-Reply-To: <20171024133535.GC13445@arm.com>
References: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com>
        <20171024133535.GC13445@arm.com>
Organization: Arm
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 24 Oct 2017 14:35:35 +0100
Will Deacon <will.deacon@arm.com> wrote:

> On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote:
> > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror()
> > so each arch can start to customize usability for its h/w PMU drivers.
> > 
> > Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> > ---
> >  tools/perf/arch/x86/util/Build   |  1 +
> >  tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++
> >  tools/perf/util/evsel.c          | 21 +++++++++++++++------
> >  tools/perf/util/evsel.h          |  2 ++
> >  4 files changed, 42 insertions(+), 6 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/evsel.c
> 
> This looks sensible to me, although it's difficult to justify all of the
> parameters to perf_evsel__suppl_strerror judging by this patch alone.

I looked at possibly reducing the number of parameters, but since both
evsel and target elements are used to evaluate the condition the error
occurred in, and err, msg, and size are required for basic strerror
functioning, they all look to stay: see the shared strerror function to
see how they're all used.

Thanks,

Kim