From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932691AbdJYB6u (ORCPT ); Tue, 24 Oct 2017 21:58:50 -0400 Received: from fldsmtpe03.verizon.com ([140.108.26.142]:63256 "EHLO fldsmtpe03.verizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbdJYB5N (ORCPT ); Tue, 24 Oct 2017 21:57:13 -0400 From: "Levin, Alexander (Sasha Levin)" Cc: =?utf-8?B?Tm9yYWxmIFRyw7hubmVz?= , Daniel Vetter , "Levin, Alexander (Sasha Levin)" X-Host: pioneer.tdc.vzwcorp.com To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 4.4 07/25] drm: drm_minor_register(): Clean up debugfs on failure Thread-Topic: [PATCH AUTOSEL for 4.4 07/25] drm: drm_minor_register(): Clean up debugfs on failure Thread-Index: AQHTTTRww0xVFKcfx02gNLJPvYWioQ== Date: Wed, 25 Oct 2017 01:56:14 +0000 Message-ID: <20171025015607.24625-7-alexander.levin@verizon.com> References: <20171025015607.24625-1-alexander.levin@verizon.com> In-Reply-To: <20171025015607.24625-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="utf-8" Content-ID: <26C163AC9BA71D488799E2ED057F3ADC@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9P1wtUx012080 From: Noralf Trønnes [ Upstream commit a67834f8bfa1e2f48bb27d07b9a552ba7c3af82a ] Call drm_debugfs_cleanup() in case drm_debugfs_init() fails to cover for failure in the drm_driver.debugfs_init callback. Signed-off-by: Noralf Trønnes Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/20170126225621.12314-3-noralf@tronnes.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 7dd6728dd092..ccc2044af831 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -312,7 +312,7 @@ static int drm_minor_register(struct drm_device *dev, unsigned int type) ret = drm_debugfs_init(minor, minor->index, drm_debugfs_root); if (ret) { DRM_ERROR("DRM: Failed to initialize /sys/kernel/debug/dri.\n"); - return ret; + goto err_debugfs; } ret = device_add(minor->kdev); -- 2.11.0