From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbdJYEGX (ORCPT ); Wed, 25 Oct 2017 00:06:23 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:37984 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbdJYEGU (ORCPT ); Wed, 25 Oct 2017 00:06:20 -0400 Date: Wed, 25 Oct 2017 12:05:41 +0800 From: Herbert Xu To: David Miller Cc: garsilva@embeddedor.com, steffen.klassert@secunet.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG Message-ID: <20171025040541.GA1999@gondor.apana.org.au> References: <20171024032508.GC28462@gondor.apana.org.au> <20171023225043.Horde.R0FvJkHEmPPjnRNzKMOrPb3@gator4166.hostgator.com> <20171024035320.GA29795@gondor.apana.org.au> <20171024.174842.272234711073180328.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024.174842.272234711073180328.davem@davemloft.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: > > This discussion has happened before. > > But I'll explain the conclusion here for your benefit. > > BUG_ON() is a statement and everything inside of it will > always execute. > > BUG_ON() is always preferred because it allows arch > specific code to pass the conditional result properly > into inline asm and builtins for optimal code generation. This is a good point. However, while a little bit more verbose you can still achieve the same assembly-level result by something like int err; err = ; BUG_ON(err); Having real code in BUG_ON may pose problems to people reading the code because some of us tend to ignore code in BUG_ON and similar macros such as BUILD_BUG_ON. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt