From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbdJYHp1 (ORCPT ); Wed, 25 Oct 2017 03:45:27 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:54912 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbdJYHp0 (ORCPT ); Wed, 25 Oct 2017 03:45:26 -0400 X-Google-Smtp-Source: ABhQp+RSkSg3VrfrczqozcfoxGPHudll77B5g9jzN7ZfE08mq9n6XFyrY0AiTd+gFEmsgjlJd6CDKw== Date: Wed, 25 Oct 2017 08:45:15 +0100 From: Lee Jones To: =?utf-8?B?5Yav6ZSQ?= Cc: Arnd Bergmann , gregkh , Linux Kernel Mailing List , "ricky_wu@realtek.com" Subject: Re: =?utf-8?B?562U5aSNOiBbUEFUQw==?= =?utf-8?Q?H?= 1/2] misc: rtsx: Move Realtek Card Reader Driver to misc Message-ID: <20171025074515.okrgwowfpuzlgedd@dell> References: <1508383343-21429-1-git-send-email-rui_feng@realsil.com.cn> <20171023093518.cnqultuil4srzxjk@dell> <20171024104349.55hhv3kt3xgesz7q@dell> <2A308283684ECD4B896628E09AF5361E01A741FE@RS-MBS01.realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2A308283684ECD4B896628E09AF5361E01A741FE@RS-MBS01.realsil.com.cn> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Oct 2017, 冯锐 wrote: > > On Tue, 24 Oct 2017, Arnd Bergmann wrote: > > > > > On Mon, Oct 23, 2017 at 11:35 AM, Lee Jones wrote: > > > > On Thu, 19 Oct 2017, Arnd Bergmann wrote: > > > > > > > >> On Thu, Oct 19, 2017 at 5:22 AM, wrote: > > > >> > From: Rui Feng > > > >> > > > > >> > Because Realtek PCIE card reader driver is a pcie driver, and it > > > >> > bridges mmc subsystem and memstick subsystem, it's not a mfd > > > >> > driver. Greg and Lee Jones had a discussion about where to put > > > >> > the driver, the result is that misc is a good place for it, so I > > > >> > move all files to misc. If I don't move it to a right place, I > > > >> > can't add any patch for this driver. > > > >> > > > > >> > Signed-off-by: Rui Feng > > > >> > --- > > > >> > drivers/memstick/host/rtsx_pci_ms.c | 2 +- > > > >> > drivers/mfd/Kconfig | 11 ----------- > > > >> > drivers/mfd/Makefile | 2 -- > > > >> > drivers/misc/Kconfig | 1 + > > > >> > drivers/misc/Makefile | 1 + > > > >> > drivers/misc/realtek/Kconfig | 10 ++++++++++ > > > >> > drivers/misc/realtek/Makefile | 3 +++ > > > >> > drivers/{mfd => misc/realtek}/rtl8411.c | 1 - drivers/{mfd => > > > >> > misc/realtek}/rts5209.c | 1 - drivers/{mfd => > > > >> > misc/realtek}/rts5227.c | 1 - > > > >> > > > >> Thanks for redoing the patch. If Lee and Greg want to see it moved > > > >> here, I won't object, but I'd still like to understand the > > > >> distinction better, since there are likely going to be other > > > >> drivers in the same situation (either adding into misc or mfd) and > > > >> it would be good if we can all give consistent advice. > > > >> > > > >> Greg, Lee: can you come up with a simple definition of what an MFD > > > >> is that this driver does not fit into? What about other PCI drivers > > > >> like intel-lpss-pci and lpc_ich? Are they different from this one > > > >> or should they also be moved out of MFD? > > > > > > > > MFDs drivers don't *do* anything. They handle shared resources, > > > > register featureful devices residing in other subsystems and provide > > > > simple shared functionality pertaining to the chip as a whole. > > > > > > > > These card reader devices *are* the featureful drivers and brim with > > > > useful functionality. > > > > > > > > intel-lpss-pci and lpc_ich conform to the aforementioned definition. > > > > > > Ok. I think we have some other drivers in MFD that fall into similar > > > categories as rtsx, maybe the db8500 prcmu for instance, but it > > > > Yes, the rts drivers should be moved as they do not conform and are still in > > active development. And I agree that there is an argument for the x8500 set > > to be considered as platform drivers. However, since they are now stable I > > see no reason to move them unnecessarily. > > > > > does sound like a reasonable definition. If we ever get too many > > > drivers like rtsx in drivers/misc, we may have to come up with a new > > > place for them. > > > > Agreed. > > > > > For now > > > > > > Acked-by: Arnd Bergmann > > > > Thanks. > > > > Rui, please add this to your set. > > > Do you mean adding " Acked-by: Arnd Bergmann " to my set or something else? Yes. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog