From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-efi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
Kweh Hock Leong <hock.leong.kweh@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>
Subject: [PATCH 1/2] efi/capsule-loader: pr_err() strings should end with newlines
Date: Wed, 25 Oct 2017 11:14:18 +0100 [thread overview]
Message-ID: <20171025101419.26369-2-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20171025101419.26369-1-ard.biesheuvel@linaro.org>
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kweh Hock Leong <hock.leong.kweh@intel.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/firmware/efi/capsule-loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c
index ec8ac5c4dd84..51d2874942a2 100644
--- a/drivers/firmware/efi/capsule-loader.c
+++ b/drivers/firmware/efi/capsule-loader.c
@@ -49,7 +49,7 @@ int __efi_capsule_setup_info(struct capsule_info *cap_info)
pages_needed = ALIGN(cap_info->total_size, PAGE_SIZE) / PAGE_SIZE;
if (pages_needed == 0) {
- pr_err("invalid capsule size");
+ pr_err("invalid capsule size\n");
return -EINVAL;
}
--
2.11.0
next prev parent reply other threads:[~2017-10-25 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 10:14 [GIT PULL 0/2] EFI updates for v4.15 Ard Biesheuvel
2017-10-25 10:14 ` Ard Biesheuvel [this message]
2017-10-25 10:14 ` [PATCH 2/2] arm64: efi: ignore EFI_MEMORY_XP attribute if RP and/or WP are set Ard Biesheuvel
2017-12-26 10:40 ` [GIT PULL 0/2] EFI updates for v4.15 Ard Biesheuvel
2017-12-27 18:46 ` Ingo Molnar
2017-12-28 22:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025101419.26369-2-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®