From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdJYOxp (ORCPT ); Wed, 25 Oct 2017 10:53:45 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:44910 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbdJYOxj (ORCPT ); Wed, 25 Oct 2017 10:53:39 -0400 X-Google-Smtp-Source: ABhQp+QHonSQPGn3fVNvYdCRhqZeT6PDCy98GVhUO6d+O5YUDiyu07puDI6cq9hLew5+GLLjvvnNTA== Date: Wed, 25 Oct 2017 09:53:37 -0500 From: Rob Herring To: Raveendra Padasalagi Cc: MyungJoo Ham , Chanwoo Choi , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute Message-ID: <20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop> References: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote: > Add documentation on optional dt attribute "debounce-timeout-ms" > in extcon node to capture user specified timeout value for id > and vbus gpio detection. > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Srinath Mannam > --- > > Changes in v2: > Rename debounce-timeout-ms to input-debounce > > Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++ > 1 file changed, 3 insertions(+) Sorry, but extcon bindings should be scrapped IMO and I don't want to see additions. "extcon" is a Linuxism and is the first clue. What's needed is a full USB connector binding, not just some incomplete handling of ID and Vbus pins. There's some work happening on that[1]. Rob [1] https://www.spinics.net/lists/linux-usb/msg161106.html