From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbdJYVyu (ORCPT ); Wed, 25 Oct 2017 17:54:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42534 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdJYVyr (ORCPT ); Wed, 25 Oct 2017 17:54:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7F3534ACA7 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=alex.williamson@redhat.com Date: Wed, 25 Oct 2017 23:54:46 +0200 From: Alex Williamson To: Colin King Cc: Joerg Roedel , iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: remove unused variable flush_addr Message-ID: <20171025235446.3ab07cfb@t450s.home> In-Reply-To: <20171022114945.1479-1-colin.king@canonical.com> References: <20171022114945.1479-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 25 Oct 2017 21:54:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Oct 2017 13:49:45 +0200 Colin King wrote: > From: Colin Ian King > > Variable flush_addr is being assigned but is never read; it > is redundant and can be removed. Cleans up the clang warning: > > drivers/iommu/amd_iommu.c:2388:2: warning: Value stored to 'flush_addr' > is never read > > Signed-off-by: Colin Ian King > --- > drivers/iommu/amd_iommu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index 5a72f40d6532..a99d41fc3a1d 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -2382,11 +2382,9 @@ static void __unmap_single(struct dma_ops_domain *dma_dom, > size_t size, > int dir) > { > - dma_addr_t flush_addr; > dma_addr_t i, start; > unsigned int pages; > > - flush_addr = dma_addr; > pages = iommu_num_pages(dma_addr, size, PAGE_SIZE); > dma_addr &= PAGE_MASK; > start = dma_addr; Applied to iommu/updates for v4.15, thanks, Alex