From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdJZIgf convert rfc822-to-8bit (ORCPT ); Thu, 26 Oct 2017 04:36:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59458 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbdJZIgc (ORCPT ); Thu, 26 Oct 2017 04:36:32 -0400 Date: Thu, 26 Oct 2017 17:36:26 +0900 (KST) Message-Id: <20171026.173626.1982523888757754892.davem@davemloft.net> To: Haakon.Bugge@oracle.com Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs From: David Miller In-Reply-To: <20171024141628.14637-1-Haakon.Bugge@oracle.com> References: <20171024141628.14637-1-Haakon.Bugge@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Oct 2017 01:36:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Håkon Bugge Date: Tue, 24 Oct 2017 16:16:28 +0200 > The number of unsignaled work-requests posted to the IB send queue is > tracked by a counter in the rds_ib_connection struct. When it reaches > zero, or the caller explicitly asks for it, the send-signaled bit is > set in send_flags and the counter is reset. This is performed by the > rds_ib_set_wr_signal_state() function. > > However, this function is not always used which yields inaccurate > accounting. This commit fixes this, re-factors a code bloat related to > the matter, and makes the actual parameter type to the function > consistent. > > Signed-off-by: Håkon Bugge Applied.