From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370AbdJZK4A (ORCPT ); Thu, 26 Oct 2017 06:56:00 -0400 Received: from smtprelay0182.hostedemail.com ([216.40.44.182]:60830 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932141AbdJZKz7 (ORCPT ); Thu, 26 Oct 2017 06:55:59 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2903:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4362:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12050:12438:12663:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:14777:21063:21080:21433:21627:30022:30030:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pet99_33d4f05d6a115 X-Filterd-Recvd-Size: 1824 Date: Thu, 26 Oct 2017 06:55:51 -0400 From: Steven Rostedt To: Julien Thierry Cc: linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] trace: fix undefined tracing functions build error Message-ID: <20171026065551.0e8126ba@vmware.local.home> In-Reply-To: <1509007060-24191-1-git-send-email-julien.thierry@arm.com> References: <1509007060-24191-1-git-send-email-julien.thierry@arm.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Oct 2017 09:37:40 +0100 Julien Thierry wrote: > When selecting CONFIG_PREEMPTIRQ_EVENTS without CONFIG_DEBUG_PREEMPT, > trace_preempt_(en|dis)able_* names do not get defined. This causes a build > error in function trace_preempt_off (kernel/trace/trace_irqsoff.c) when > CONFIG_PREEMPT_TRACER is enabled. > > Similarly, when selecting CONFIG_PREEMPTIRQ_EVENTS and > CONFIG_PROVE_LOCKING, trace_irq_(en|dis)able_* names do not get defined, > although it seems they do not get referenced in that configuration. > > Ensure trace_(irq|preempt)_* names are always defined, becoming empty > macros in the cases where they were not defined previously. > Thanks, But I've seen another patch that I believe fixes this issue, but I'm currently traveling in Prague, and attending several conferences there, and haven't had time to look at my email. When I get home next week I'll be applying patches sent to me. Thanks, -- Steve