From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbdJZRnZ (ORCPT ); Thu, 26 Oct 2017 13:43:25 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42100 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932309AbdJZRnX (ORCPT ); Thu, 26 Oct 2017 13:43:23 -0400 Date: Thu, 26 Oct 2017 19:43:07 +0200 From: Peter Zijlstra To: Tejun Heo Cc: Li Zefan , Johannes Weiner , Ingo Molnar , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat Message-ID: <20171026174307.GU3165@worktop.lehotels.local> References: <20171023231827.GA8598@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171023231827.GA8598@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote: > The basic cpu stat is currently shown with "cpu." prefix in > cgroup.stat, and the same information is duplicated in cpu.stat when > cpu controller is enabled. This is ugly and not very scalable as we > want to expand the coverage of stat information which is always > available. > > This patch makes cgroup core always create "cpu.stat" file and show > the basic cpu stat there and calls the cpu controller to show the > extra stats when enabled. This ensures that the same information > isn't presented in multiple places and makes future expansion of basic > stats easier. > > Signed-off-by: Tejun Heo > Documentation/cgroup-v2.txt | 15 +++------- > include/linux/cgroup-defs.h | 2 + > include/linux/cgroup.h | 2 - > kernel/cgroup/cgroup-internal.h | 1 > kernel/cgroup/cgroup.c | 60 ++++++++++++++++++++++++++++++++++++++-- > kernel/cgroup/stat.c | 10 +++--- > kernel/sched/core.c | 13 ++------ > 7 files changed, 75 insertions(+), 28 deletions(-) Acked-by: Peter Zijlstra (Intel)