From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Thiebaud Weksteen <tweek@google.com>
Cc: linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org,
tpmdd-devel@lists.sourceforge.net,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
linux-kernel@vger.kernel.org, Matthew Garrett <mjg59@google.com>,
peterhuewe@gmx.de,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd@selhorst.net
Subject: Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices
Date: Thu, 26 Oct 2017 20:58:53 +0200 [thread overview]
Message-ID: <20171026185853.bfh7jidixrxb6ozj@linux.intel.com> (raw)
In-Reply-To: <CA+zpnLc038dv-WAE7fdD8i6DpGV3zCLEieg-KPTAvaW7yt-tLA@mail.gmail.com>
On Tue, Oct 17, 2017 at 10:00:15AM +0200, Thiebaud Weksteen wrote:
> This patch was mainly developed and tested on Kabylake with PTT as well.
>
> It could be a few things. Are you booting with the EFI stub? Is the
> TPM enabled within the BIOS? Does tpm_tis get loaded? Does it produce
> any log?
Nope, and it should not get loaded anyway as I'm using PTT. With PTT you
use tpm_crb. TPM is working just fine.
> If the logs are recovered (but not parsed), you should already see an
> entry in the logs like:
>
> efi: SMBIOS=0x7fed6000 ACPI=0x7ff00000 TPMEventLog=0x.....
>
> Can you see the TPMEventLog part?
I can check this when I'm back in Finland. Still in Prague. Tried to
test this with my work laptop (XPS13 with dTPM) now but the USB stick I
have with seems to be broken :-(
This is anyway almost guaranteed to go to 4.16 and I don't want to push
this to 4.15 so there is no rush right now (already sent my PR).
> The issue with extra logging is that the log recovery happens within
> the EFI stub phase where limited logging is available (which I think
> has been limited to error and fatal message only).
> For now, it cannot be a version mismatch as the stub will only request
> the version 1.2 format.
Right, I see.
/Jarkko
next prev parent reply other threads:[~2017-10-26 18:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:13 [PATCH v3 0/5] Call GetEventLog " Thiebaud Weksteen
2017-09-20 8:13 ` [PATCH v3 1/5] tpm: move tpm_eventlog.h outside of drivers folder Thiebaud Weksteen
2017-09-20 8:13 ` [PATCH v3 2/5] tpm: rename event log provider files Thiebaud Weksteen
2017-09-26 11:10 ` Jarkko Sakkinen
2017-09-20 8:13 ` [PATCH v3 3/5] tpm: add event log format version Thiebaud Weksteen
2017-09-20 8:13 ` [PATCH v3 4/5] efi: call get_event_log before ExitBootServices Thiebaud Weksteen
2017-09-26 11:45 ` Jarkko Sakkinen
2017-09-26 12:49 ` Thiebaud Weksteen
2017-09-29 17:16 ` Jarkko Sakkinen
2017-10-04 10:51 ` Jarkko Sakkinen
2017-10-04 11:12 ` Thiebaud Weksteen
2017-10-10 14:14 ` Jarkko Sakkinen
2017-10-11 1:54 ` James Morris
2017-10-11 11:52 ` Jarkko Sakkinen
2017-10-11 11:53 ` Jarkko Sakkinen
2017-10-12 11:38 ` Jarkko Sakkinen
2017-10-12 15:03 ` Javier Martinez Canillas
2017-10-13 19:47 ` Jarkko Sakkinen
2017-10-16 11:34 ` Jarkko Sakkinen
2017-10-16 11:28 ` Jarkko Sakkinen
2017-10-16 11:49 ` Jarkko Sakkinen
2017-10-17 8:00 ` Thiebaud Weksteen
2017-10-18 15:11 ` Jarkko Sakkinen
2017-10-26 18:58 ` Jarkko Sakkinen [this message]
2017-10-04 11:20 ` Jarkko Sakkinen
2018-03-05 15:40 ` Marc-André Lureau
2018-03-06 10:15 ` Thiebaud Weksteen
2017-09-20 8:13 ` [PATCH v3 5/5] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen
2017-09-20 16:40 ` Jason Gunthorpe
2017-09-21 15:13 ` [PATCH v3 0/5] Call GetEventLog before ExitBootServices Jarkko Sakkinen
2017-09-26 11:17 ` [tpmdd-devel] " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026185853.bfh7jidixrxb6ozj@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mjg59@google.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome