From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbdJ0DBs (ORCPT ); Thu, 26 Oct 2017 23:01:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43590 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932443AbdJ0DBp (ORCPT ); Thu, 26 Oct 2017 23:01:45 -0400 Date: Fri, 27 Oct 2017 12:01:41 +0900 (KST) Message-Id: <20171027.120141.2030619458420639672.davem@davemloft.net> To: mika.westerberg@linux.intel.com Cc: andreas.noever@gmail.com, michael.jamet@intel.com, yehezkel.bernat@intel.com, dan.carpenter@oracle.com, amir.jer.levy@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thunderbolt: Drop sequence number check from tb_xdomain_match() From: David Miller In-Reply-To: <20171025092734.51299-1-mika.westerberg@linux.intel.com> References: <20171025092734.51299-1-mika.westerberg@linux.intel.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Oct 2017 20:01:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mika Westerberg Date: Wed, 25 Oct 2017 12:27:34 +0300 > Commit 9a03c3d398c1 ("thunderbolt: Fix a couple right shifting to zero > bugs") revealed an issue that was previously hidden because we never > actually compared received XDomain message sequence numbers properly. > The idea with these sequence numbers is that the responding host uses > the same sequence number that was in the request packet which we can > then check at the requesting host. > > However, testing against macOS it looks like it does not follow this but > instead uses some other logic. Windows driver on the other hand handles > it the same way than Linux. > > In order to be able to talk to macOS again, fix this so that we drop the > whole sequence number check. This effectively works exactly the same > than it worked before the aforementioned commit. This also follows the > logic the original P2P networking code used. > > Signed-off-by: Mika Westerberg > --- > This applies on top of net-next.git/master. Applied, thank you.