From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbdJ0O4U (ORCPT ); Fri, 27 Oct 2017 10:56:20 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50908 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbdJ0O4L (ORCPT ); Fri, 27 Oct 2017 10:56:11 -0400 Date: Fri, 27 Oct 2017 23:56:07 +0900 (KST) Message-Id: <20171027.235607.430416647630428682.davem@davemloft.net> To: garsilva@embeddedor.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bcmgenet: Use BUG_ON instead of if condition followed by BUG From: David Miller In-Reply-To: <20171026121601.GA6113@embeddedor.com> References: <20171026121601.GA6113@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Oct 2017 07:56:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 26 Oct 2017 07:16:01 -0500 > Use BUG_ON instead of if condition followed by BUG. > > Something to notice in this particular case is that unlikely() > is already being called inside BUG_ON macro. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.