From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbdJ0HtS (ORCPT ); Fri, 27 Oct 2017 03:49:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:49591 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdJ0HtQ (ORCPT ); Fri, 27 Oct 2017 03:49:16 -0400 Date: Fri, 27 Oct 2017 09:49:12 +0200 From: Borislav Petkov To: Zhou Chengming Cc: mingo@redhat.com, tglx@linutronix.de, peterz@infradead.org, hpa@zytor.com, jkosina@suse.cz, rostedt@goodmis.org, mjurczyk@google.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp Message-ID: <20171027074912.GB1305@nazgul.tnic> References: <1509088692-9971-1-git-send-email-zhouchengming1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1509088692-9971-1-git-send-email-zhouchengming1@huawei.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 03:18:12PM +0800, Zhou Chengming wrote: > In the current code, we don't free smp_alt_modules when enable smp, > so have to wait module unload to call alternatives_smp_module_del() > to free its smp_alt_module. This strategy has shortcomings. I love it when the commit message states there is allegedly some problem but it doesn't explain what that problem is. >>From the looks of the patch, though, I'd prefer what we do now and not touch the code. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --