From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdJ0InT (ORCPT ); Fri, 27 Oct 2017 04:43:19 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:52024 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdJ0InQ (ORCPT ); Fri, 27 Oct 2017 04:43:16 -0400 X-Google-Smtp-Source: ABhQp+Q/9H9V4OhPXQzD0w3L8kltGhJkfeuSLif9w840QgyTKLfzX8XyQyfy3gaViThnADSWizkHwg== Date: Fri, 27 Oct 2017 10:43:12 +0200 From: Ingo Molnar To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, arnd@arndb.de, peterz@infradead.org Subject: Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init() Message-ID: <20171027084312.k2ay4pfh6h3ajatn@gmail.com> References: <20171023134948.24886-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171023134948.24886-1-jgross@suse.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Juergen Gross wrote: > Don't try to set the static virt_spin_lock_key to a value before > jump_label_init() has been called, as this will result in a WARN(). > > Solve the problem by introducing a new lock_init() hook called after > jump_label_init() instead of doing the call inside of > smp_prepare_boot_cpu(). > > Signed-off-by: Juergen Gross > --- > Based on kernel/git/tip/tip.git locking/core Just a quick ping: what's the conclusion of the discussion, do we want this patch as-is? Also, it's unclear from the changelog under what circumstances this bug was observed and what symptoms there are and how severe the bug - can the warning trigger on vanilla v4.14? Thanks, Ingo