From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Jeetesh Burman <jburman@nvidia.com>
Cc: sergey.senozhatsky@gmail.com, keescook@chromium.org,
linux-kernel@vger.kernel.org, bbasu@nvidia.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2] panic: add support to update panic_timeout via DT
Date: Fri, 27 Oct 2017 18:53:14 +0900 [thread overview]
Message-ID: <20171027095314.GA724@tigerII.localdomain> (raw)
In-Reply-To: <1509097165-15695-1-git-send-email-jburman@nvidia.com>
Cc-ing Andrew on this
v1: lkml.kernel.org/r/1509076662-22253-1-git-send-email-jburman@nvidia.com
lkml.kernel.org/r/20171027080006.GA609@tigerII.localdomain
v2: lkml.kernel.org/r/1509097165-15695-1-git-send-email-jburman@nvidia.com
-ss
On (10/27/17 15:09), Jeetesh Burman wrote:
> Add support to set 'panic_timeout' value via dtb to have
> control from device tree. This makes sense when you have
> multiple platforms support from same defconfig and
> differentiated only through device tree blob.
> The patch will check for panic time out value coming
> from dtb if it exists, otherwise continues with
> defconfig provided option.
>
> Signed-off-by: Jeetesh Burman <jburman@nvidia.com>
> ---
> kernel/panic.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index bdd18af..b487331 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -27,6 +27,7 @@
> #include <linux/console.h>
> #include <linux/bug.h>
> #include <linux/ratelimit.h>
> +#include <linux/of.h>
>
> #define PANIC_TIMER_STEP 100
> #define PANIC_BLINK_SPD 18
> @@ -482,9 +483,15 @@ static u64 oops_id;
>
> static int init_oops_id(void)
> {
> - if (!oops_id)
> + struct device_node *np;
> +
> + if (!oops_id) {
> + np = of_find_node_by_name(NULL, "panic_timeout");
> + if (np)
> + of_property_read_u32(np, "panic-timeout-value",
> + &panic_timeout);
> get_random_bytes(&oops_id, sizeof(oops_id));
> - else
> + } else
> oops_id++;
>
> return 0;
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-10-27 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 9:39 Jeetesh Burman
2017-10-27 9:53 ` Sergey Senozhatsky [this message]
2017-10-27 12:00 ` Lorenzo Pieralisi
2017-10-27 10:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027095314.GA724@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bbasu@nvidia.com \
--cc=jburman@nvidia.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®