From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbdJ0MFp (ORCPT ); Fri, 27 Oct 2017 08:05:45 -0400 Received: from foss.arm.com ([217.140.101.70]:58156 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbdJ0MFm (ORCPT ); Fri, 27 Oct 2017 08:05:42 -0400 Date: Fri, 27 Oct 2017 11:37:52 +0100 From: Mark Rutland To: Lorenzo Pieralisi Cc: Sergey Senozhatsky , Jeetesh Burman , keescook@chromium.org, linux-kernel@vger.kernel.org, bbasu@nvidia.com, Andrew Morton , robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH V2] panic: add support to update panic_timeout via DT Message-ID: <20171027103752.vomjgxkax725zb77@salmiak> References: <1509097165-15695-1-git-send-email-jburman@nvidia.com> <20171027095314.GA724@tigerII.localdomain> <20171027115957.GA32605@red-moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171027115957.GA32605@red-moon> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 01:00:06PM +0100, Lorenzo Pieralisi wrote: > [+devicetree, Rob, Frank] > > On Fri, Oct 27, 2017 at 06:53:14PM +0900, Sergey Senozhatsky wrote: > > Cc-ing Andrew on this > > > > > > v1: lkml.kernel.org/r/1509076662-22253-1-git-send-email-jburman@nvidia.com > > lkml.kernel.org/r/20171027080006.GA609@tigerII.localdomain > > > > v2: lkml.kernel.org/r/1509097165-15695-1-git-send-email-jburman@nvidia.com > > > > -ss > > > > On (10/27/17 15:09), Jeetesh Burman wrote: > > > Add support to set 'panic_timeout' value via dtb to have > > > control from device tree. This makes sense when you have > > > multiple platforms support from same defconfig and > > > differentiated only through device tree blob. > > > The patch will check for panic time out value coming > > > from dtb if it exists, otherwise continues with > > > defconfig provided option. > > I will let Rob and Frank chime in - as far as I am concerned > you are (ab)using DT to configure a Linux kernel specific internal > variable and that's certainly not what DT is there for. Indeed. NAK to this patch. Regardless, this can easily be configured in /chosen/bootargs (i.e. the kernel command line) today. Thanks, Mark. > > Lorenzo > > > > Signed-off-by: Jeetesh Burman > > > --- > > > kernel/panic.c | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/panic.c b/kernel/panic.c > > > index bdd18af..b487331 100644 > > > --- a/kernel/panic.c > > > +++ b/kernel/panic.c > > > @@ -27,6 +27,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #define PANIC_TIMER_STEP 100 > > > #define PANIC_BLINK_SPD 18 > > > @@ -482,9 +483,15 @@ static u64 oops_id; > > > > > > static int init_oops_id(void) > > > { > > > - if (!oops_id) > > > + struct device_node *np; > > > + > > > + if (!oops_id) { > > > + np = of_find_node_by_name(NULL, "panic_timeout"); > > > + if (np) > > > + of_property_read_u32(np, "panic-timeout-value", > > > + &panic_timeout); > > > get_random_bytes(&oops_id, sizeof(oops_id)); > > > - else > > > + } else > > > oops_id++; > > > > > > return 0; > > > -- > > > 2.1.4 > > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html