From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752678AbdJ0Oam (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 10:30:42 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:39068 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752613AbdJ0Oae (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 10:30:34 -0400
Date: Fri, 27 Oct 2017 17:30:21 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Cc: ruxandra.radulescu@nxp.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment
Message-ID: <20171027143020.m7zlhptw4nl2xy3n@mwanda>
References: <1509113496-10810-1-git-send-email-bogdan.purcareata@nxp.com>
 <1509113496-10810-5-git-send-email-bogdan.purcareata@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1509113496-10810-5-git-send-email-bogdan.purcareata@nxp.com>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 27, 2017 at 02:11:35PM +0000, Bogdan Purcareata wrote:
> @@ -93,10 +100,10 @@
>   * buffers large enough to allow building an skb around them and also account
>   * for alignment restrictions
>   */
> -#define DPAA2_ETH_BUF_RAW_SIZE \
> +#define DPAA2_ETH_BUF_RAW_SIZE(priv) \
>  	(DPAA2_ETH_RX_BUF_SIZE + \
>  	SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \
> -	DPAA2_ETH_RX_BUF_ALIGN)
> +	(priv)->rx_buf_align)
>  

Not related to this patch, but this macro is ugly.  It would be better
as function.

regards,
dan carpenter