From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751893AbdJ0Ojc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 10:39:32 -0400
Received: from mail-oi0-f68.google.com ([209.85.218.68]:57253 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752799AbdJ0OiR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 10:38:17 -0400
X-Google-Smtp-Source: ABhQp+RLsDYPKR2vzSHnB5QNY/iXoxhydolep2XKLEipr30x17M1oW1XPVJzfvQ+Ar2jShHROY3aJw==
Date: Fri, 27 Oct 2017 09:38:15 -0500
From: Rob Herring <robh@kernel.org>
To: Philippe Cornu <philippe.cornu@st.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Russell King <linux@armlinux.org.uk>,
        Mark Rutland <mark.rutland@arm.com>,
        Archit Taneja <architt@codeaurora.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@linux.ie>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Bhumika Goyal <bhumirks@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Yannick Fertre <yannick.fertre@st.com>,
        Vincent Abriou <vincent.abriou@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Gabriel Fernandez <gabriel.fernandez@st.com>,
        Ludovic Barre <ludovic.barre@st.com>,
        Fabien Dessenne <fabien.dessenne@st.com>,
        Mickael Reulier <mickael.reulier@st.com>
Subject: Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory
 property
Message-ID: <20171027143815.evbb7rqkgqiol7yo@rob-hp-laptop>
References: <1509034356-23885-1-git-send-email-philippe.cornu@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1509034356-23885-1-git-send-email-philippe.cornu@st.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
> Note: Fix also the DSI panel example where "ref" & "pclk"
> clocks were swapped.
> 
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
>  Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 0292522..99823fb 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI:
>  - #size-cells: Should be <0>.
>  - compatible: "st,stm32-dsi".
>  - clock-names:
> +  - DPI/RGB input pixel clock string name, must be "px_clk".
>    - phy pll reference clock string name, must be "ref".

Where's pclk?

The new clock should be last to be backwards compatible.

>  - resets: see [5].
>  - reset-names: see [5].
> @@ -97,8 +98,9 @@ Example 2: DSI panel
>  			#size-cells = <0>;
>  			compatible = "st,stm32-dsi";
>  			reg = <0x40016c00 0x800>;
> -			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> -			clock-names = "ref", "pclk";
> +			clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>,
> +				 <&clk_hse>;
> +			clock-names = "pclk", "px_clk", "ref";
>  			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>  			reset-names = "apb";
>  
> -- 
> 1.9.1
>