From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752635AbdJ0SVv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 14:21:51 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:55442 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752539AbdJ0SVs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 14:21:48 -0400
X-Google-Smtp-Source: ABhQp+TXsmpOvrBQ7FRaOxW7QHWPZzuDF1HSCY6BXO4WzM4mDxzbcx0Af9xQiTkoS56k5sfeVoan9g==
Date: Fri, 27 Oct 2017 20:21:43 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, cmetcalf@mellanox.com,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        torvalds@linux-foundation.org, hpa@zytor.com, riel@redhat.com,
        cl@linux.com, efault@gmx.de, kernellwp@gmail.com,
        paulmck@linux.vnet.ibm.com, lcapitulino@redhat.com,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/isolation: Document the isolcpus= flags
Message-ID: <20171027182143.2zbnvqjfwkc5whtf@gmail.com>
References: <1509072159-31808-13-git-send-email-frederic@kernel.org>
 <tip-98a06af93784a6ae541e9fc6292ef26177832543@git.kernel.org>
 <20171027135831.GZ3165@worktop.lehotels.local>
 <CAFTL4hxLPZGPgwVnoh9SrEicymA=XSVLuwCwLQiohWYOha93gQ@mail.gmail.com>
 <20171027170632.mxwfe5hd4cmlguvb@gmail.com>
 <CAFTL4hzJSc1PbNaZ3AFEi_Wn=80SDn0tbNXZFm_EzGr24a74-g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFTL4hzJSc1PbNaZ3AFEi_Wn=80SDn0tbNXZFm_EzGr24a74-g@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Frederic Weisbecker <frederic@kernel.org> wrote:

> 2017-10-27 19:06 UTC+02:00, Ingo Molnar <mingo@kernel.org>:
> >
> > * Frederic Weisbecker <frederic@kernel.org> wrote:
> >
> >> 2017-10-27 15:58 UTC+02:00, Peter Zijlstra <peterz@infradead.org>:
> >> > On Fri, Oct 27, 2017 at 05:06:25AM -0700, tip-bot for Frederic
> >> > Weisbecker
> >> > wrote:
> >> >> +	isolcpus=	[KNL,SMP] Isolate a given set of CPUs from disturbance.
> >> >> +			Format: [flag-list,]<cpu-list>
> >> >> +
> >> >> +			Specify one or more CPUs to isolate from disturbances
> >> >> +			specified in the flag list (default: domain):
> >> >> +
> >> >> +			nohz
> >> >> +			  Disable the tick when a single task runs.
> >> >> +			domain
> >> >> +			  Isolate from the general SMP balancing and scheduling
> >> >> +			  algorithms. This option is the preferred way to isolate
> >> >> +			  CPUs from tasks.
> >> >
> >> > I _strongly_ object to this statement, isolcpus is _not_ the preferred
> >> > way, cpusets are.
> >> >
> >> > And yes, while cpusets suffers some problems, we _should_ really fix
> >> > those and not promote this piece of shit isolcpus crap.
> >>
> >> I definitely agree with that so your position is a relief :-) This
> >> patch only indented the existing parameter documentation so fixing its
> >> content was beyond its scope. I'll send a patch to correct the text.
> >
> > Since it was the last commit in tip:sched/core that was pushed out just
> > hours ago
> > I zapped that last commit, please send an updated patch which we can apply
> > and get
> > a clean series.
> >
> > Thanks,
> 
> Note the issue was there before that patch. But nevermind  I'll resend
> an updated version of the patch.

Yeah - so we get a single 'improve documentation' commit.

Thanks,

	Ingo