From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315AbdJ0TEw (ORCPT ); Fri, 27 Oct 2017 15:04:52 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43011 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdJ0TEu (ORCPT ); Fri, 27 Oct 2017 15:04:50 -0400 X-Google-Smtp-Source: ABhQp+QazZhaK3ab5901XlSXcG32ruzvxO0mhvooTJhzZDyk3HwyIpzGu8bqetLVknPtW0rAF1RiNw== Date: Fri, 27 Oct 2017 21:04:46 +0200 From: Ingo Molnar To: Frederic Weisbecker Cc: Peter Zijlstra , cmetcalf@mellanox.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, hpa@zytor.com, riel@redhat.com, cl@linux.com, efault@gmx.de, kernellwp@gmail.com, paulmck@linux.vnet.ibm.com, lcapitulino@redhat.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:sched/core] sched/isolation: Document the isolcpus= flags Message-ID: <20171027190446.miszsgfu5ijwjz4n@gmail.com> References: <1509072159-31808-13-git-send-email-frederic@kernel.org> <20171027135831.GZ3165@worktop.lehotels.local> <20171027170632.mxwfe5hd4cmlguvb@gmail.com> <20171027182143.2zbnvqjfwkc5whtf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > 2017-10-27 20:21 UTC+02:00, Ingo Molnar : > > > > * Frederic Weisbecker wrote: > > > >> 2017-10-27 19:06 UTC+02:00, Ingo Molnar : > >> > > >> > * Frederic Weisbecker wrote: > >> > > >> >> 2017-10-27 15:58 UTC+02:00, Peter Zijlstra : > >> >> > On Fri, Oct 27, 2017 at 05:06:25AM -0700, tip-bot for Frederic > >> >> > Weisbecker > >> >> > wrote: > >> >> >> + isolcpus= [KNL,SMP] Isolate a given set of CPUs from disturbance. > >> >> >> + Format: [flag-list,] > >> >> >> + > >> >> >> + Specify one or more CPUs to isolate from disturbances > >> >> >> + specified in the flag list (default: domain): > >> >> >> + > >> >> >> + nohz > >> >> >> + Disable the tick when a single task runs. > >> >> >> + domain > >> >> >> + Isolate from the general SMP balancing and scheduling > >> >> >> + algorithms. This option is the preferred way to isolate > >> >> >> + CPUs from tasks. > >> >> > > >> >> > I _strongly_ object to this statement, isolcpus is _not_ the > >> >> > preferred > >> >> > way, cpusets are. > >> >> > > >> >> > And yes, while cpusets suffers some problems, we _should_ really fix > >> >> > those and not promote this piece of shit isolcpus crap. > >> >> > >> >> I definitely agree with that so your position is a relief :-) This > >> >> patch only indented the existing parameter documentation so fixing its > >> >> content was beyond its scope. I'll send a patch to correct the text. > >> > > >> > Since it was the last commit in tip:sched/core that was pushed out just > >> > hours ago > >> > I zapped that last commit, please send an updated patch which we can > >> > apply > >> > and get > >> > a clean series. > >> > > >> > Thanks, > >> > >> Note the issue was there before that patch. But nevermind I'll resend > >> an updated version of the patch. > > > > Yeah - so we get a single 'improve documentation' commit. > > Ah ok I see. No problem I'll resend. Thanks! Ingo