From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbdJ0TGO (ORCPT ); Fri, 27 Oct 2017 15:06:14 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:56217 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdJ0TGK (ORCPT ); Fri, 27 Oct 2017 15:06:10 -0400 X-Google-Smtp-Source: ABhQp+RZmdmDgzJ/wAr45X7r1pliBe5b+MCqiFzjMUUX9u4rz3WBw+gk6lvgvNTo7uoQvT99h2wEyw== From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: alexander.levin@verizon.com, stable@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan , William Cohen , Greg Kroah-Hartman , Florian Fainelli Subject: [PATCH stable-4.1.y] tools include: Add a __fallthrough statement Date: Fri, 27 Oct 2017 12:05:58 -0700 Message-Id: <20171027190558.31241-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo commit b5bf1733d6a391c4e90ea8f8468d83023be74a2a upstream. For cases where implicit fall through case labels are intended, to let us inform that to gcc >= 7: CC /tmp/build/perf/util/string.o util/string.c: In function 'perf_atoll': util/string.c:22:7: error: this statement may fall through [-Werror=implicit-fallthrough=] if (*p) ^ util/string.c:24:3: note: here case '\0': ^~~~ So we introduce: #define __fallthrough __attribute__ ((fallthrough)) And use it in such cases. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Cc: William Cohen Link: http://lkml.kernel.org/n/tip-qnpig0xfop4hwv6k4mv1wts5@git.kernel.org Fixes: ed8306908374 ("perf top: Use __fallthrough") Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman Signed-off-by: Florian Fainelli --- tools/include/linux/compiler.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/include/linux/compiler.h b/tools/include/linux/compiler.h index 88461f09cc86..8717c80f759c 100644 --- a/tools/include/linux/compiler.h +++ b/tools/include/linux/compiler.h @@ -37,4 +37,12 @@ #define ACCESS_ONCE(x) (*(volatile typeof(x) *)&(x)) +#ifndef __fallthrough +# if defined(__GNUC__) && __GNUC__ >= 7 +# define __fallthrough __attribute__ ((fallthrough)) +# else +# define __fallthrough +# endif +#endif + #endif /* _TOOLS_LINUX_COMPILER_H */ -- 2.14.1