From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbdJ1BPg (ORCPT ); Fri, 27 Oct 2017 21:15:36 -0400 Received: from smtprelay0240.hostedemail.com ([216.40.44.240]:45920 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750915AbdJ1BPe (ORCPT ); Fri, 27 Oct 2017 21:15:34 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2689:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3870:3871:3872:3873:3874:4605:5007:6261:6690:7875:7903:10010:10400:10848:10967:11026:11232:11658:11914:12043:12050:12663:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21063:21080:21434:21627:30012:30054:30056:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: wave82_30553387c1735 X-Filterd-Recvd-Size: 2284 Date: Fri, 27 Oct 2017 21:15:27 -0400 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Ingo Molnar , Andrew Morton , stable Subject: Re: [GIT PULL] tracing/samples: Fix creation and deletion of simple_thread_fn creation Message-ID: <20171027211527.6ebf5da4@vmware.local.home> In-Reply-To: References: <20171017172150.3ff71046@gandalf.local.home> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Oct 2017 16:59:49 -0700 Linus Torvalds wrote: > I'm back home, which means I do full builds, and that in turn shows > that this was garbage. Unfortunately, I'm still in Prague, but I just finished my marathon of presentations. > > On Tue, Oct 17, 2017 at 2:21 PM, Steven Rostedt wrote: > > > > Please pull the latest trace-v4.14-rc3 tree, which can be found at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > > trace-v4.14-rc3 > > This causes a compiler warning, for a very valid reason: > > > +static bool simple_thread_cnt; > > > > int foo_bar_reg(void) > > { > > + mutex_lock(&thread_mutex); > > + if (simple_thread_cnt++) > > + goto out; > > Yeah., take a closer look at that. It's complete and utter BS. > > Please send a fix asap, or I'll just revert. Yes, it is. Being sample code it doesn't get tested in my test suite (I should fix that) and this is the first pull request I sent you that didn't go through the testing (because my test suit wouldn't even test it). I'll write up a fix on the plane home on Saturday. Expect something by Sunday. Sorry about that. :-/ -- Steve