mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	David Carrillo-Cisneros <davidcc@google.com>,
	kernel-team@fb.com
Subject: [PATCH] cgroup, perf_event: Fix perf cgroup hierarchy support
Date: Sat, 28 Oct 2017 09:49:37 -0700	[thread overview]
Message-ID: <20171028164237.GA972780@devbig577.frc2.facebook.com> (raw)

864c2357ca89 ("perf/core: Do not set cpuctx->cgrp for unscheduled
cgroups") made list_update_cgroup_event() skip setting cpuctx->cgrp if
no cgroup event targets %current's cgroup.  This breaks perf_event's
hierarchical support because events which target one of the ancestors
get ignored.

Fix it by using cgroup_is_descendant() test instead of equality.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 864c2357ca89 ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups")
Cc: stable@vger.kernel.org # v4.9+
Cc: David Carrillo-Cisneros <davidcc@google.com>
---
 kernel/events/core.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 9d93db8..db2e630 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -901,9 +901,12 @@ list_update_cgroup_event(struct perf_event *event,
 	cpuctx_entry = &cpuctx->cgrp_cpuctx_entry;
 	/* cpuctx->cgrp is NULL unless a cgroup event is active in this CPU .*/
 	if (add) {
+		struct perf_cgroup *cgrp = perf_cgroup_from_task(current, ctx);
+
 		list_add(cpuctx_entry, this_cpu_ptr(&cgrp_cpuctx_list));
-		if (perf_cgroup_from_task(current, ctx) == event->cgrp)
-			cpuctx->cgrp = event->cgrp;
+		if (cgroup_is_descendant(cgrp->css.cgroup,
+					 event->cgrp->css.cgroup))
+			cpuctx->cgrp = cgrp;
 	} else {
 		list_del(cpuctx_entry);
 		cpuctx->cgrp = NULL;

             reply	other threads:[~2017-10-28 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28 16:49 Tejun Heo [this message]
2017-10-30 10:20 ` Peter Zijlstra
2017-10-30 11:26 ` [tip:perf/urgent] perf/cgroup: " tip-bot for Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171028164237.GA972780@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=acme@kernel.org \
    --cc=davidcc@google.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome