From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbdJ2PyX (ORCPT ); Sun, 29 Oct 2017 11:54:23 -0400 Received: from mail-bn3nam01on0064.outbound.protection.outlook.com ([104.47.33.64]:5968 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750916AbdJ2PyV (ORCPT ); Sun, 29 Oct 2017 11:54:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@cavium.com; Date: Sun, 29 Oct 2017 18:54:09 +0300 From: Yury Norov To: Kien Ha Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Yury Norov Subject: Re: [PATCH] Fix line too long warning Message-ID: <20171029155409.5pntisfklykssda4@yury-thinkpad> References: <1509245173.3669.5.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509245173.3669.5.camel@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [95.104.161.7] X-ClientProxiedBy: VI1PR0801CA0085.eurprd08.prod.outlook.com (2603:10a6:800:7d::29) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 530a874c-d68e-4e3c-3e67-08d51ee5508b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1;DM5PR0701MB3832;3:h95KujBDpmSu/BqqvLX1a2JkdFMDCx6puIhgAa869Dg6tZIOlOa3r6V5kU6Lpr4aJ+DLD/S9ixedPyfO6vmKn/5G2yEnKzP9q6nnRknoxmskMLzgLggdB5oALsrPPu1QKuN9TwLq6gwTTRqLRZtO8qaM46WQ8+TE304o0u0vYxttq9kTuBdlAzt7754Ew80GmiBXkECryzFZUgMEcOyyjaNalojOTcW0nG45k8plj5yo6h/c2rE9m4e2GOjgSNRj;25:51phHhkCGRot+pTWa7FUFqtlIpnzHHgNKXpeFByqXbqwVQF2or/RM4GG2HVzJ9sxJlI8Y1NNi1+PM74gqW5nf836Svol6Fs1AwwolEn+zleQpW1YJw9gROSYFBgcbnDxYXb9tEXw/Sgeu989b/TaWg5ZvAzC9ASi221lHKbwzwxYkLwycXJEqwIhjuqVQXmpoEbWVWoUQl8VkQWus0WOLYYdGdNx3iUO+LSCEZae50KJRknbz9jn6Ht32hIwJkNvbfhmHbzaGP1VzOy3WLO2PVHG48ErK4/XvqCn2at6oDhbXpgoIYuSfrUstH6RgBJC9pObaua/2KkxHezYD1JxkA==;31:A9cG1RJeGsvGdC50YmYF3oysDMvZn+5RlMXAzmSvynNuK9H8tWDKFzpa8BnL8/HkFQu75XmhF79zQk1TmOYU8jO5OZAPDZavIVWSejYRWIN7temmkBdG7Hy0a7HpAAgJukN8Ku7xIsCxwNLZ+0ythQT88A3ovQ3XdJXNidJz1VwbTTy5rZzZGqI135p9Wb6tIT51BrrotTTJgdSP2g2aslMeLBJLRH4LUwURQmDq4vc= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1;DM5PR0701MB3832;20:ffPJ4SL8x8U3RfqlW25cZEvExNcSpADKf64zyBG+VjA1JDlrxTmCzofbmgEGuSLSWxmC0psIRQj8Y9KiaE5pasJi3MsyqM+AFmJ0iCbUXpbM28drDPmE87ebn7X864Y8eKq3aCsJrGchcx7+K1e7DMrxgV5lwLWSN8qVjMYC21gAc6b+lUPTU6XjEUAwpGpoRAqnOnNbICBBq0kQ4QYTbWVyzCu2fqho8v6GRgP73jCT9SSQtLtlmpL0q1Ytfc5R/4ccp1J9aeq67TLLcmNU5m5scSC1eUOKzvRgKGmAKp4JqO9xjY5rLHy+LEmoLBIrHl/UPSSz+YKK8A/1l4XNnhjTu+95irOnPsl3Fb5iIzTSynvRQ+qq8CRkQo+5iBmp8Q5a6M1JydNOpbXlGQUo4lVYn+6A8um0svDbXMsZx1scem867w1oOh3dVwVs0cEfQ7TjSVamecG70eeUXzJB13hZQBVmcvyKqIotGWXefdFDRwxFhgwakffPynqeJX7HAUofMWbmN6p0NGAuBCVp2YmoMcCliSWIqDSd6lbZRcneePrs0osqleKHH1RlNs2UmlHilqPB5XuWOJWQXrX+sY17isIbdFrnQUEmbsb/WjU=;4:5insL+8M8/IDKZBcMGPZyVV5rnmLKu6NiD8BEoczmauOwHwk3P6oG8qt0e33vSK4iFW2AJRXnYO0yMWFr/WK/MAxNpqR05Wglfu4xGq72EQ6Te92GA7yoNpiqvrrQY+0+V8cr6NO46DuKA/L44M8zxdr3p6R5MQX9YdCltvzJCU4+PF7D7Ngf87+UWmv15+X0FNq7cnJajKDmbOKBuGpUyRqEWAtstD+afskYFVJ1KN2Da0Nr1+p55h+F47Nh+VjlZx41ocSSRZGYqdMn09gYA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(93006095)(6041248)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR0701MB3832;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 0475418F50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(7916004)(376002)(346002)(189002)(199003)(52314003)(24454002)(68736007)(8936002)(50466002)(101416001)(47776003)(16586007)(58126008)(76176999)(54356999)(83506002)(575784001)(305945005)(105586002)(478600001)(50986999)(23726003)(316002)(1076002)(6116002)(3846002)(76506005)(106356001)(97736004)(66066001)(33646002)(72206003)(6486002)(39060400002)(9686003)(53546010)(189998001)(6666003)(53936002)(6246003)(6496005)(2950100002)(2906002)(6916009)(42882006)(107886003)(1411001)(16526018)(81166006)(81156014)(8676002)(5660300001)(25786009)(33716001)(229853002)(4326008)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR0701MB3832;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR0701MB3832;23:YxLEFSUGlmdIA/f2lwRTZFLFVxF4vHvxMEYWC5e?= =?us-ascii?Q?hbJHVKffNhITJ/ncTheo5EIfLhyBHjr9zpA2PUDNHQF/NP/ghFH24YUC7gmN?= =?us-ascii?Q?vTqx30JO3Kemw4BatBpJRF9xaCHQ23GJkZZKrbcmWWB0YdXFxDJyiSDCGYlq?= =?us-ascii?Q?rLxWFzjermUMgircSPwuzecnwbcsWG7SYNxjNrTGiCSGY+11r4+0HmNmJhIR?= =?us-ascii?Q?REULReMaLewoX7E26+h4A0kTLxNFIAXM9p+K1XIGWRjrmzO6xWg7K4vltYH2?= =?us-ascii?Q?wI3wG1AJsPsEIw1C/W+hlSNBCh6n72ufANFvXOtOUq+Sd0RDwxlzaUlV4RUM?= =?us-ascii?Q?LN9ICR1cCdcRBJ/Qw/QNsylsPU4v2nXzjFzCh0e7bUaM4TLi6JeV+7ls8WnK?= =?us-ascii?Q?HrYfwtmi2gOJY/X4Ru4+63LYm/NG8GHMp7g6ZNTtmKmQbND3yRFWHLIM4c6l?= =?us-ascii?Q?iXisCBvLi5svZ4bQp3Y8WeeSBxkNpfW37VD5QOaxWOhyuy7VEb19Z0SvzzuD?= =?us-ascii?Q?zBPqcBQPPmjSdz7d+cHt35jkfPUum/5xSG4QGJfScHRJgoWfIq5jhe8lFJ8y?= =?us-ascii?Q?XPpDK/v2zdYnSVsQpd5sqs309kc7ogu+ZGaHSw53A8mbcKriQxTnBmhsDs3K?= =?us-ascii?Q?QF/UQ6QAdbJogzPkJDp5GsZmZBtXRSuqtylle+SJjuHgzqQRKw9QIS/ewxaD?= =?us-ascii?Q?koCS+JxM+2MzpVWqgBRNqZM6CYNaNWVB7FnNuvQ0lmw+EDBcsQO7ZD6YlGzQ?= =?us-ascii?Q?WlpoOdGcqg0EqVuXod6dAAJuNAFlgR/8+zOQbWefIdTOViLQCvdtT8iFeNrB?= =?us-ascii?Q?Y2xGA7rm2AG82eUzICQQgCXQxrTb6QKbfV/Iwn2/S55Qsjl1P5zXvhuG+tbw?= =?us-ascii?Q?qyaMeMv4FD57eeGNFr377Dh1XPtvVHb9ZqrusZVwLsipQb2ULhKRmCUV7q/o?= =?us-ascii?Q?5kZ7IcaDiHm9TAwgOuA62k5NnfAd9bfDaV7Kz+emAdBLnBOIFDCApN2M7ZFh?= =?us-ascii?Q?TbSUNXFpD+lWXTXgMMXYGWSo5m6cTEj0uaFYDf3BXVBBIK7Da6Ckfwz//xxM?= =?us-ascii?Q?hjlzVf8RQ1s43pownw2UlqwSxITx4bKA6YhPIzgK35FAXkMoiVMRpGE3Ea8E?= =?us-ascii?Q?IWkvR1ImgaaRl7gsR/YB+H7vNlPfTdY+Mf/9G8E6lkfypgikKPJ/ufs3PSid?= =?us-ascii?Q?TxRNixcdNCAacSZV8VqK+oL0s7yPKWt7U6CeWpASMa3N4RcC8eFujFg5NU2W?= =?us-ascii?Q?zJ1pBFSP3K/N6EBFQ8daTgNiZ9AgvNBwx4GG5MRAinxKrh9oxdRJVWujHczd?= =?us-ascii?Q?MyUOIzAypwZ7I6eifbRlwCAr3NTUPG/NHjzmhueKgRfHnKVB7zth22+q8pCM?= =?us-ascii?Q?0Q3qEQc1tdbP0/bSSlvNGmFBuY7E=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR0701MB3832;6:kFjS0lAnlI7HxkTaX4Ni0Xas+XAZc5GLfcDZpVyzEj7R6z3LP36Ddajt4fz1pa6y4ScM1zQzPdlDWL0P+t1wqWyrOnF1/IoJ9j2f1vEgRYyK0nyQZe1PO4IfHj100VhJFVQZd2QGlmd7qz3wvweLxm291g9nkgv19eUuTLXRNKzR9epBQNDtDZWoHOU0XMGYVbw0LLtkH3w8JQ83+Ds1o8YGFY6Sd6ruM2vx2YbdpCVd5dw6FzZIEzs5pw50QANGqaifBL4bWpIudmvVEGpDdqsY04AaxmM84lroZZKoWhKBKcRIgvTnD0TPc4DqLttUfgAe7xg1VFkA5xBR9zDLC6mwbQ7UoTA7GxwCSBJZRwI=;5:5XgMS3L0zcYmQmli4sZFWlrqVwbm2eFTrZfRIz29QVx63x35cUYCgPkAtfCDzVzIBkidf/sMXarwx77zX7WxrGJb8nCgYjWDDCoxkSPN949cZGpaaH+0QWLrst97IGBXWUoRPLgRAR5hQ5EbdRZUIqSa30w35SNT2kLCqPK+zoY=;24:zXMNkxWXnf8mnsRavyT/Xh56g76E5e+bBXGJ0vFd3CglV4O7WldsZb3iX3hjhkxUrGWbrhQclfVLYyXu4Vy+lMXxFPEdt+hMFsDXAC/9bDU=;7:sgFCVy4qgRnJCOq1QMUsI1HPtRa8TNF/5AyBv9uur1EiAo+oWd8pO+MRvKytXaXK92dS6tv1j1+a1OZ7jiPJGqPPyWKD2SnM2B/8g+entOl/7u/m+pgdat0xCbBEoM0GT7prIz3KFDf5ZyIDuSygHru4k5pBdx31KaJUjfyYdlLkZHsZu/VQgH9FlRxqC35hFePInXRDTj7y+Kggj+EPo8ehV8xRnPRK4PX6eOc2+HjdyovFoDoZDfvLJ+jF5s+m SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2017 15:54:18.5596 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 530a874c-d68e-4e3c-3e67-08d51ee5508b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kien, On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > >From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > From: Kien Ha > Date: Fri, 27 Oct 2017 14:07:55 -0400 > Subject: [PATCH] Fix line too long warning > > Signed-off-by: Kien Ha > --- > drivers/staging/rtlwifi/base.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c > index b88b0e8edd3d..bbc80f976e12 100644 > --- a/drivers/staging/rtlwifi/base.c > +++ b/drivers/staging/rtlwifi/base.c > @@ -1283,7 +1283,8 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw, > } else { > if (rtlmac->mode == WIRELESS_MODE_B) { > tcb_desc->hw_rate = > - rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M]; > + rtlpriv->cfg->maps[ > + RTL_RC_CCK_RATE11M]; At first, if you fix this, you should also fix similar problem 3 lines below, right? > } else { > tcb_desc->hw_rate = > rtlpriv->cfg->maps[RTL_RC_OFDM_RATE54M]; At second, and most important, refer Documentation/process/coding-style.rst: Now, some people will claim that having 8-character indentations makes the code move too far to the right, and makes it hard to read on a 80-character terminal screen. The answer to that is that if you need more than 3 levels of indentation, you're screwed anyway, and should fix your program. The real problem here is not "line too long", but "indentation level too big" - 5. And it worth to address real problem. Yury