From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdJ2Q30 (ORCPT ); Sun, 29 Oct 2017 12:29:26 -0400 Received: from mail-cys01nam02on0047.outbound.protection.outlook.com ([104.47.37.47]:29022 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751366AbdJ2Q3Y (ORCPT ); Sun, 29 Oct 2017 12:29:24 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@cavium.com; Date: Sun, 29 Oct 2017 19:29:09 +0300 From: Yury Norov To: Kien Ha Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] Fix line too long warning Message-ID: <20171029162908.a7cyroinb72eryhu@yury-thinkpad> References: <1509245173.3669.5.camel@gmail.com> <20171029155409.5pntisfklykssda4@yury-thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171029155409.5pntisfklykssda4@yury-thinkpad> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [95.104.161.7] X-ClientProxiedBy: DB3PR0202CA0009.eurprd02.prod.outlook.com (2603:10a6:8:1::22) To MWHPR0701MB3834.namprd07.prod.outlook.com (2603:10b6:301:7f::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 516edf3c-a8ad-4e4f-7979-08d51eea355b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:MWHPR0701MB3834; X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3834;3:tCFopwT7kcx0szR7pno37uc11wPIQM/jnP78np/FjIm6kJzwjHt1JzrBlaIdcgZYII7ZfubaUaYekPnoeMA3Qv6/Uim2XHapC82WSCiK1ZXZbE6UOEcI608yoSPw5Rro1XV2heMjEfTTn3guJ1/huswaHKoWPfjSCdINlLv0x6zPgsPezU/PKiL5jQGBMh6njsYH2qZFhcJ8WBeMvMWtrGHHUS51almtU3PgjZKlj65l1vVmSE1dAAP8ePXnzdBx;25:HhF9eHZG+65aIvVj6UXP7/v6nKHc6NOS4x1kBIJmmjJkJ6IfSZpl6gIBEcfyMl53N1Yef8uFFs18ChMAUg4/dHobTQ8inJdaK7u+mnMOyj0rIO7oHMBXTU4pHGL/qwgOzq9NlH8BmFvacrv5UCdaKRPRhgbXM3TlmJXTyWf1jnymbL4+67lCo5mkcVUaTycfDvsYbib9L7lWbBnr56uJD7z4vYwosLP4SqRBGXOHzH2qnkKWCFtoDKTZT/if/05QLH1LfVlsplFprG+ILM7sa4M4sJleTQwJAk+2oFJhK9ht8M4FcB3qOneKOepV7kdCWTWx72Cc9BI+i/ENzXXW2g==;31:hC6HTCzZo+Fmcp+eAVY1M2PeAZ1JOAKaOq1/JCHt34qrwRqA3HTH8+W6t+gQXsp94jrRgaDkQykSdgLlgDWiYlzas/ywoGzkGVjl7ylgQhWaC92QC6oWWg5WOlycnkxLF59wSjWNBT2slS7l5In1llQ3e6q1/I9BqieSCeMEqiy3f6gMa9CXRysuTmcrxumILtcsgemfYDdzz+/SyRmeFIIZEyBz40vsFbTZyhTV8H8= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3834: X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3834;20:bZDys8Cf8D66oOGmpb13cU8oEYY/GznzyieI5/zwGGRMfFPHmO6ySb2KbLff92ndZQI/cCn1Fc+5JiXvKYZFDAoIhnvGv5FZDXcWBi/JZvTygqHO/pmyaS6lkmydbXX30ie+dnu6e6btmQSljX7F+XuRkn24Wue+AU7LJlB+65NNfkScVvlGUMY+N0RSnrrfskKAmxco7FVn5tx+fW7hX+vi9dSYKFeEygopApnJKjahS41GJ7OdH/fzNJukaY0YJXWrGus+qJVBS4uLCtxaOOFJLkqXFYFxW5Pedq4X1vKDe9Thro1glv2q6lBEFQvKfgjs1JWsVA8fgB+07jTrZtOMAwGy7NIstwU6GSaoC31F4wLEutJ2FbUlKoZggtC/Wtylwj5LuToAmNCInxNLMOw28eh980s/K95J45QkbaZAkEcWKmXGFbv2U017Q5rhZi0ESIU9wPcTG3RDHYt1dRvIFgq/Iub5mfZA7PIEoo3xKtk8W5VbEox1RrKKja6xHNdT59cnjVqqu85UyEjNzqzehUNOtVngl2YYuTyGE9lF2VGZoJZz2w9pEDeIozj7IA/8ycxyprih1XgF5JERRiEz2Z8Jr9OgNu7FkPCTIOw=;4:Y/iwaznpJBQ8GbW/s9fJTTHJq2m72sxk/jfKTq0M5LNBq5jX/kftx83WvNGnsC62k5tuf7psTWl4O3P2puK+xTwwdkyXD9wPeSWk8c1nA20/rIJ4xXRyGiRn8mgXCz49UDpueJuWAnhYZ7UoHXuRquZcvly649Iq4lmeAsHUuwLs+46gteVtHUAhfa32BOa6B19PqDZ7LelOp7oUuhtKg53UtUi8tw40vMqS17dSliFY+rtWAUiIifBR20FSOtTkQl37w9RMorR5KFhGZtyb9w== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(3231020)(93006095)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR0701MB3834;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR0701MB3834; X-Forefront-PRVS: 0475418F50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(7916004)(346002)(376002)(199003)(24454002)(189002)(52314003)(6916009)(53936002)(81166006)(6666003)(76506005)(105586002)(2950100002)(42882006)(39060400002)(6486002)(6116002)(3846002)(4326008)(6246003)(33646002)(575784001)(5660300001)(53546010)(97736004)(83506002)(106356001)(1411001)(16526018)(2906002)(72206003)(50466002)(6496005)(33716001)(25786009)(9686003)(68736007)(50986999)(76176999)(54356999)(478600001)(316002)(16586007)(101416001)(58126008)(47776003)(8936002)(8676002)(81156014)(66066001)(1076002)(23726003)(229853002)(7736002)(305945005)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR0701MB3834;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR0701MB3834;23:kBFP02CO7HAgwsTQcvsZxDugRC1F7s0E4K/C+Sq?= =?us-ascii?Q?aYYWq/FaZkzvf+vvDS6Cyfu5R9JHJ411O2BWEKMp/nHLYxYK8QA2xN/PKRUg?= =?us-ascii?Q?/g4Ree7K/61M1Jh6mCueg9BwUj/m1Sm1Gc6vtMntBhAOAN68q2+J2Z8dNAHs?= =?us-ascii?Q?dOP7PVCPE2qRutvD19NRQ1RT7ok19VmV3n8LNtuDsn2wLxbWLsPA2BK2faO/?= =?us-ascii?Q?iCLtqZ7+E1NfxW8U3a08VPiZmyOXqxKiS4XbU3kiHSYHgZrtIGLXxLlLyVsA?= =?us-ascii?Q?lIQApgykmPbjqDFfupqgzBb3ehAMAWg8lp4Qj4jsmpt9MEKIDGD7mUxrfr9Y?= =?us-ascii?Q?0EdfB+1Lqefxjs5soBHSY+09v+EyOVL0dE/eqG7kN4eP3OroTelY8dPWmSzO?= =?us-ascii?Q?gLijRWdALtkAPhV2cfaTthzJRFkf9XvK1Wdu469Jd5jygD3PB85cYYKrg2R4?= =?us-ascii?Q?k3VQTUTwyBtV0cZGtUSpg/NcOpmcvrGrTlfnyeIuRF/QGgSwC5j7DEqcJT+V?= =?us-ascii?Q?M/pAKQvR5daZIkZa5MCZtmBiRWkCJ0tylKj65W90Ozwspag0wSC8X5SSWUdc?= =?us-ascii?Q?BWG+ODTBJ6Jcz5bn/j0Z5gMvhsmFDM3IT2ERsjLEAU3YKWvT4zWSbtln9xRF?= =?us-ascii?Q?HFUllPVD70InS2e36X2d6G8n+qSFFFxP/SP8uZw+2yBtSrqFCPVGQkw39hb1?= =?us-ascii?Q?UKDLAwg0EsEIoOwcUJznqwKQi1lOEtvIh9PfM9qPqmMIS1icA0/M6qpxmCEz?= =?us-ascii?Q?+VbmJS4o5w1Hmv4SKI8Cb7+q5lBhDIprMkXSt+5h1BijdZW6dPDHRsfSh9Cp?= =?us-ascii?Q?E1oTzEcQjE2tiN8Aa5uq6dFdoiB9XYzmHLw3wjkhLtKHkf5hYLDQur9JBKQt?= =?us-ascii?Q?lhl2Ag89oB0FzOBp3CcruioQhi6leJIPzyhUviLAZHFpDCKokM8DfJ38X05/?= =?us-ascii?Q?N+cGGKU/jHB793DuAKqTlSMnCBUkXvo/1tg/D0H0jMl95ATkQXt7KSSp6jjG?= =?us-ascii?Q?dvHWkBJ8/hEKgUBFpQK1gutYKIT3dH4L/Ev/nKEAlBAqfEWoz73wX+lckwpD?= =?us-ascii?Q?m0KtomW5IQZQmKhAtMEuU3DW29AOhQkQyn7FIlgkO0enphZG/ep/AV+ei1WG?= =?us-ascii?Q?MUVo0mrjFKTuNASntoefQr+PCDSIu0Kh0e/hgHPwvUsqTfpBYWFuC6TOrxje?= =?us-ascii?Q?C1Hoc08kxhWp+K4fNHMPr0xlmSCtz1DrWl7oBdDIRzULExZKInwM3139LOPY?= =?us-ascii?Q?60NLI+9eVnREd6G7qJbwPhaeEpTkCtxeCHf/XkArMZG02m8mShPox3DLTFGl?= =?us-ascii?Q?BaqnkSXi++hcwXnenjj8LMlsScnH2ZeEcz9qYLmdgzD5d4Gvb+B/r305U8GE?= =?us-ascii?Q?VfQkYDA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3834;6:FLRQ1y3LY2gIb84cFoaLUOPPPFBsHvEVlpAxUClX2fAUak6H02Nz65ujwo8NeBb3P884o758SCxFdlzM93TrSl7tQ2hbMR180JHPucluzRF+gH5mnk9wxiS8VUGdyBf5wzmFRjzyIkTn44saOWRg2KpUFaPAUNxUQUlgdspItGF1uy092dr6v3V3oF/juXB2cqAU9+hee9hPEFuhpf5rlCmWgXXF9p2ypgVGEyUBSPMeMaGBZneGhU5u1hXmAfCOvga6WdYzuPzAAmjPpnePEOJ6nWq/cqeZ4m9PDRwK60LuPPiJ69j/zzq2qgLekhUyTQADWGBxvkcpZo7OdGcyui2TQG7sYnMtSdDGNWMZwHY=;5:70eAtLjslWTQunzggnsOl7XG8umU/LXH/xIQs/9LK6qamTtKMtCvfQyR+RyxStRcZ1JQhSPQG2DgmIDa2WSKBVIZHAE6ooQeC8dRYdnE/6nmVC+cnj018uFPFdvsY1VuP4KIHsab7LAve7xDmAr6AD6vqi81kRtswhiSWPZ2Fy0=;24:64F+rWxFedI6byLwB20moPR68gnw1y0UcVHjsekzbES665u335P9yRNIEsxpaGOtGjCJGaT3Zgtr/QGHrIVlvwLRS81uMtuoZuU4s5fo+ss=;7:ElFcqfPsTbKrfG58Ra6o825OZCT9tiPtYuWdxK1Ev+V+4qAmey/I/cIYSIFTzcUYMGijqQ10hxQRldNjij87XJWa3Q3K0T6Nxj76W7qO9djLmkwaL5fl9pI6+iqChJ9XsA3TMTJfg9gi5EZJgmnD1a41PR+4M/sKYYFJfOr2l6clGuo1st+hKAQgptnxshfh5wL81N/5ZBWA9xfUhIaQcN3yUiTRENdr0ogCIOuW+iWzASdg2N4Xos3M/JtOmplm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2017 16:29:20.4004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 516edf3c-a8ad-4e4f-7979-08d51eea355b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3834 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 29, 2017 at 06:54:09PM +0300, Yury Norov wrote: > Hi Kien, > > On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > > >From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > > From: Kien Ha > > Date: Fri, 27 Oct 2017 14:07:55 -0400 > > Subject: [PATCH] Fix line too long warning > > > > Signed-off-by: Kien Ha > > --- > > drivers/staging/rtlwifi/base.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c > > index b88b0e8edd3d..bbc80f976e12 100644 > > --- a/drivers/staging/rtlwifi/base.c > > +++ b/drivers/staging/rtlwifi/base.c > > @@ -1283,7 +1283,8 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw, > > } else { > > if (rtlmac->mode == WIRELESS_MODE_B) { > > tcb_desc->hw_rate = > > - rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M]; > > + rtlpriv->cfg->maps[ > > + RTL_RC_CCK_RATE11M]; > > At first, if you fix this, you should also fix similar problem 3 lines > below, right? > > > } else { > > tcb_desc->hw_rate = > > rtlpriv->cfg->maps[RTL_RC_OFDM_RATE54M]; > > At second, and most important, refer Documentation/process/coding-style.rst: > Now, some people will claim that having 8-character indentations makes > the code move too far to the right, and makes it hard to read on a > 80-character terminal screen. The answer to that is that if you need > more than 3 levels of indentation, you're screwed anyway, and should fix > your program. > > The real problem here is not "line too long", but "indentation level too > big" - 5. And it worth to address real problem. It's not so hard though, something like this: void rtl_get_tcb_desc(struct ieee80211_hw *hw, struct ieee80211_tx_info *info, struct ieee80211_sta *sta, struct sk_buff *skb, struct rtl_tcb_desc *tcb_desc) { #define SET_RATE_ID(rate_id) \ ((rtlpriv->cfg->spec_ver & RTL_SPEC_NEW_RATEID) ? \ rtl_mrate_idx_to_arfr_id(hw, rate_id, \ (sta_entry ? sta_entry->wireless_mode : \ WIRELESS_MODE_G)) : \ rate_id) struct rtl_priv *rtlpriv = rtl_priv(hw); struct rtl_mac *rtlmac = rtl_mac(rtl_priv(hw)); struct ieee80211_hdr *hdr = rtl_get_hdr(skb); struct rtl_sta_info *sta_entry = (sta ? (struct rtl_sta_info *)sta->drv_priv : NULL); __le16 fc = rtl_get_fc(skb); tcb_desc->hw_rate = _rtl_get_tx_hw_rate(hw, info); if (rtl_is_tx_report_skb(hw, skb)) tcb_desc->use_spe_rpt = 1; if (!ieee80211_is_data(fc)) { tcb_desc->use_driver_rate = true; tcb_desc->ratr_index = SET_RATE_ID(RATR_INX_WIRELESS_MC); tcb_desc->disable_ratefallback = 1; tcb_desc->mac_id = 0; tcb_desc->packet_bw = false; return; } if (is_multicast_ether_addr(hdr->addr1)) tcb_desc->multicast = 1; else if (is_broadcast_ether_addr(hdr->addr1)) tcb_desc->broadcast = 1; /* * we set data rate INX 0 in rtl_rc.c if skb is special data or * mgt which need low data rate. So tcb_desc->hw_rate is just used * for special data and mgt frames */ if (info->control.rates[0].idx == 0 || ieee80211_is_nullfunc(fc)) { tcb_desc->use_driver_rate = true; tcb_desc->ratr_index = SET_RATE_ID(RATR_INX_WIRELESS_MC); tcb_desc->disable_ratefallback = 1; goto rtl_query; } /* because hw will never use hw_rate * when tcb_desc->use_driver_rate = false * so we never set highest N rate here, * and N rate will all be controlled by FW * when tcb_desc->use_driver_rate = false */ if (sta && sta->vht_cap.vht_supported) { tcb_desc->hw_rate = _rtl_get_vht_highest_n_rate(hw, sta); goto rtl_query; } if (sta && (sta->ht_cap.ht_supported)) { tcb_desc->hw_rate = _rtl_get_highest_n_rate(hw, sta); goto rtl_query; } if (rtlmac->mode == WIRELESS_MODE_B) tcb_desc->hw_rate = rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M]; else tcb_desc->hw_rate = rtlpriv->cfg->maps[RTL_RC_OFDM_RATE54M]; rtl_query: _rtl_txrate_selectmode(hw, sta, tcb_desc); _rtl_query_bandwidth_mode(hw, sta, tcb_desc); _rtl_qurey_shortpreamble_mode(hw, tcb_desc, info); _rtl_query_shortgi(hw, sta, tcb_desc, info); _rtl_query_protection_mode(hw, tcb_desc, info); #undef SET_RATE_ID } (Compeletely untested and most probably wrong, just illustration.) Yury