From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbdJ3Dhn (ORCPT ); Sun, 29 Oct 2017 23:37:43 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:53687 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdJ3Dhm (ORCPT ); Sun, 29 Oct 2017 23:37:42 -0400 X-Google-Smtp-Source: ABhQp+RLDs7h0ZY1FpI/gLDr2lVsbJqRut7rI6bJm5SeuGs1zMq6O29ZfRKjThKG6lm3piTer5gsIQ== Date: Mon, 30 Oct 2017 09:07:38 +0530 From: Viresh Kumar To: Randy Dunlap Cc: Greg Kroah-Hartman , Vincent Guittot , Stephen Boyd , Rajendra Nayak , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robdclark@gmail.com, s.hauer@pengutronix.de, l.stach@pengutronix.de, shawnguo@kernel.org, fabio.estevam@nxp.com, nm@ti.com, xuwei5@hisilicon.com, robh+dt@kernel.org Subject: Re: [PATCH V4 07/12] boot_constraint: Add debugfs support Message-ID: <20171030033738.GG4240@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-10-17, 08:09, Randy Dunlap wrote: > On 10/29/17 06:48, Viresh Kumar wrote: > > This patch adds debugfs support for boot constraints. This is how it > > looks for a "vmmc-supply" constraint for the MMC device. > > > > Tested-by: Rajendra Nayak > > Signed-off-by: Viresh Kumar > > --- > > drivers/boot_constraints/clk.c | 3 ++ > > drivers/boot_constraints/core.c | 60 +++++++++++++++++++++++++++++++++++++++ > > drivers/boot_constraints/core.h | 6 ++++ > > drivers/boot_constraints/pm.c | 11 +++++-- > > drivers/boot_constraints/supply.c | 9 ++++++ > > 5 files changed, 87 insertions(+), 2 deletions(-) > > Hi, > Does this build OK when CONFIG_DEBUG_FS is not enabled? > > I didn't see any depends on or select DEBUG_FS or any use of > CONFIG_DEBUG_FS in any Makefile. As soon as I saw your reply, it looked like I have seen this email earlier. :) https://marc.info/?l=linux-kernel&m=149866480929111&w=2 And yes, it builds just fine as all the dummy helpers are in place. -- viresh