From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbdJ3IR6 (ORCPT ); Mon, 30 Oct 2017 04:17:58 -0400 Received: from sym2.noone.org ([178.63.92.236]:47543 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbdJ3IR5 (ORCPT ); Mon, 30 Oct 2017 04:17:57 -0400 Date: Mon, 30 Oct 2017 09:17:54 +0100 From: Tobias Klauser To: Pan Bian Cc: Yisen Zhuang , Salil Mehta , "David S. Miller" , lipeng , Kejian Yan , Lin Yun Sheng , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: hns: set correct return value Message-ID: <20171030081753.GG1370@distanz.ch> References: <1509287732-32172-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509287732-32172-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-10-29 at 15:35:32 +0100, Pan Bian wrote: > The function of_parse_phandle() returns a NULL pointer if it cannot > resolve a phandle property to a device_node pointer. In function > hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract > the error code. However, in this case, the extracted error code will > always be zero, which is unexpected. > > Signed-off-by: Pan Bian The subject is missing a [PATCH] prefix which causes the patch e.g. to not show up on patchwork [1]. Care to resend with the proper subject? [1] https://patchwork.ozlabs.org/project/netdev/list/ Care to resend with the proper subject? For the patch itself: Reviewed-by: Tobias Klauser