From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbdJ3I4H (ORCPT ); Mon, 30 Oct 2017 04:56:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36368 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbdJ3I4G (ORCPT ); Mon, 30 Oct 2017 04:56:06 -0400 Date: Mon, 30 Oct 2017 11:55:50 +0300 From: Dan Carpenter To: Bogdan Purcareata Cc: "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment Message-ID: <20171030085550.cqmladzvmysxefik@mwanda> References: <1509113496-10810-1-git-send-email-bogdan.purcareata@nxp.com> <1509113496-10810-5-git-send-email-bogdan.purcareata@nxp.com> <20171027143020.m7zlhptw4nl2xy3n@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 02:44:37PM +0000, Bogdan Purcareata wrote: > > -----Original Message----- > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > > Sent: Friday, October 27, 2017 5:30 PM > > To: Bogdan Purcareata > > Cc: Ruxandra Ioana Radulescu ; > > gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > > devel@driverdev.osuosl.org > > Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment > > > > On Fri, Oct 27, 2017 at 02:11:35PM +0000, Bogdan Purcareata wrote: > > > @@ -93,10 +100,10 @@ > > > * buffers large enough to allow building an skb around them and also > > account > > > * for alignment restrictions > > > */ > > > -#define DPAA2_ETH_BUF_RAW_SIZE \ > > > +#define DPAA2_ETH_BUF_RAW_SIZE(priv) \ > > > (DPAA2_ETH_RX_BUF_SIZE + \ > > > SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \ > > > - DPAA2_ETH_RX_BUF_ALIGN) > > > + (priv)->rx_buf_align) > > > > > > > Not related to this patch, but this macro is ugly. It would be better > > as function. > > Okay, will change the macros to inline functions in v2, where applicable. > You didn't need to do that, because I said it was "not related to this change". I try not to make people redo paches for stuff like this. But thanks, it looks nicer now. regards, dan carpenter