From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752788AbdJ3JSe (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 05:18:34 -0400
Received: from mail-pg0-f65.google.com ([74.125.83.65]:44894 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752176AbdJ3JSd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 05:18:33 -0400
X-Google-Smtp-Source: ABhQp+Q6103Gc5mlNCIBsZDlSV5iPhmQfaikKphAqNx8OSa6BkQCXRXQOPsB879kTs0MS/A93fBo+Q==
Date: Mon, 30 Oct 2017 14:48:29 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Cc: Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
        "Cc: Len Brown" <lenb@kernel.org>,
        "Cc: Juri Lelli" <juri.lelli@arm.com>,
        "Cc: Patrick Bellasi" <patrick.bellasi@arm.com>,
        "Cc: Steve Muckle" <smuckle@google.com>,
        "Cc: Brendan Jackman" <brendan.jackman@arm.com>,
        "Cc: Chris Redpath" <Chris.Redpath@arm.com>,
        "Cc: Atish Patra" <atish.patra@oracle.com>,
        "Cc: Dietmar Eggemann" <dietmar.eggemann@arm.com>,
        "Cc: Vincent Guittot" <vincent.guittot@linaro.org>,
        "Cc: Morten Ramussen" <morten.rasmussen@arm.com>,
        "Cc: EAS Dev" <eas-dev@lists.linaro.org>,
        "Cc: Android Kernel" <kernel-team@android.com>
Subject: Re: [PATCH RFC 3/5] cpufreq: schedutil: Use idle_calls counter of
 the remote CPU
Message-ID: <20171030091829.GM4240@vireshk-i7>
References: <20171028095941.4773-1-joelaf@google.com>
 <20171028095941.4773-4-joelaf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171028095941.4773-4-joelaf@google.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28-10-17, 02:59, Joel Fernandes wrote:
> Since the recent remote cpufreq callback work, its possible that a cpufreq
> update is triggered from a remote CPU. For single policies however, the current
> code uses the local CPU when trying to determine if the remote sg_cpu entered
> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick
> idle_calls counter of the remote CPU.
> 
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")

> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
>  include/linux/tick.h             |  1 +
>  kernel/sched/cpufreq_schedutil.c |  2 +-
>  kernel/time/tick-sched.c         | 13 +++++++++++++
>  3 files changed, 15 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh