From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752568AbdJ3JWw (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 05:22:52 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:53371 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752370AbdJ3JWv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 05:22:51 -0400
X-Google-Smtp-Source: ABhQp+Qe7cRqPaKdy7chjRnckGAGABXQZ4cBaGukbmE9RV7/A3PvLMpRZmT3PtZCksTdo+za+BA9Ww==
Date: Mon, 30 Oct 2017 14:52:48 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        "Cc: Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
        "Cc: Len Brown" <lenb@kernel.org>,
        "Cc: Juri Lelli" <juri.lelli@arm.com>,
        "Cc: Patrick Bellasi" <patrick.bellasi@arm.com>,
        "Cc: Steve Muckle" <smuckle@google.com>,
        "Cc: Brendan Jackman" <brendan.jackman@arm.com>,
        "Cc: Chris Redpath" <Chris.Redpath@arm.com>,
        "Cc: Atish Patra" <atish.patra@oracle.com>,
        "Cc: Dietmar Eggemann" <dietmar.eggemann@arm.com>,
        "Cc: Vincent Guittot" <vincent.guittot@linaro.org>,
        "Cc: Morten Ramussen" <morten.rasmussen@arm.com>,
        "Cc: Frederic Weisbecker" <fweisbec@gmail.com>,
        "Cc: Thomas Gleixner" <tglx@linutronix.de>,
        "Cc: EAS Dev" <eas-dev@lists.linaro.org>,
        "Cc: Android Kernel" <kernel-team@android.com>
Subject: Re: [PATCH RFC 4/5] sched/fair: Correct obsolete comment about
 cpufreq_update_util
Message-ID: <20171030092248.GN4240@vireshk-i7>
References: <20171028095941.4773-1-joelaf@google.com>
 <20171028095941.4773-5-joelaf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171028095941.4773-5-joelaf@google.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

You have prefixed most of the Cc'd names with "Cc: " somehow :)

On 28-10-17, 02:59, Joel Fernandes wrote:
> Since the remote cpufreq callback work, the cpufreq_update_util call can happen
> from remote CPUs. The comment about local CPUs is thus obsolete. Update it
> accordingly.

We normally keep the column width as 72 in commit logs instead of 80,
as with 'git log' this is indented by a tab and then we would cross 80
columns.

> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
>  kernel/sched/fair.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 4c06e52935d3..5c49fdb4c508 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3018,9 +3018,7 @@ static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
>  		/*
>  		 * There are a few boundary cases this might miss but it should
>  		 * get called often enough that that should (hopefully) not be
> -		 * a real problem -- added to that it only calls on the local
> -		 * CPU, so if we enqueue remotely we'll miss an update, but
> -		 * the next tick/schedule should update.
> +		 * a real problem.
>  		 *
>  		 * It will not get called when we go idle, because the idle
>  		 * thread is a different class (!fair), nor will the utilization

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh