From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbdJ3KWa (ORCPT ); Mon, 30 Oct 2017 06:22:30 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:47110 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdJ3KW2 (ORCPT ); Mon, 30 Oct 2017 06:22:28 -0400 X-Google-Smtp-Source: ABhQp+T5Alb724YFBCrT8YahH3WXmnVez2dGuDJm3rW8ll1mmMV+3NQH2pjBKIfy/bgey0l5IVjofg== Date: Mon, 30 Oct 2017 11:22:24 +0100 From: Daniel Vetter To: Pan Bian Cc: Patrik Jakobsson , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: gma500: mmu: unmap the correct address Message-ID: <20171030102224.55gyvgehpwzgn2f6@phenom.ffwll.local> Mail-Followup-To: Pan Bian , Patrik Jakobsson , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1509256512-5962-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509256512-5962-1-git-send-email-bianpan2016@163.com> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 29, 2017 at 01:55:12PM +0800, Pan Bian wrote: > The function kunmap_atomatic() is called on the same variable twice, > i.e. pt->v. In the second call, its parameter should be variable v > rather than pt->v. > > Signed-off-by: Pan Bian Makes sense, not sure this ever worked or how it ever worked, but oh well. Applied to drm-misc-next for 4.16. -Daniel > --- > drivers/gpu/drm/gma500/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c > index 0eaf11c..ccb161c 100644 > --- a/drivers/gpu/drm/gma500/mmu.c > +++ b/drivers/gpu/drm/gma500/mmu.c > @@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt) > psb_mmu_clflush(pd->driver, (void *)&v[pt->index]); > atomic_set(&pd->driver->needs_tlbflush, 1); > } > - kunmap_atomic(pt->v); > + kunmap_atomic(v); > spin_unlock(&pd->driver->lock); > psb_mmu_free_pt(pt); > return; > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch