From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbdJ3SFA (ORCPT ); Mon, 30 Oct 2017 14:05:00 -0400 Received: from mx3.wp.pl ([212.77.101.9]:54845 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752702AbdJ3SE6 (ORCPT ); Mon, 30 Oct 2017 14:04:58 -0400 Date: Mon, 30 Oct 2017 11:04:49 -0700 From: Jakub Kicinski To: Colin King Cc: Lino Sanfilippo , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx Message-ID: <20171030110449.3aea9670@cakuba.netronome.com> In-Reply-To: <20171029133809.6831-1-colin.king@canonical.com> References: <20171029133809.6831-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 60f8031289f9b2f6c65f5040237048e4 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [kUPE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Oct 2017 13:38:09 +0000, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: > > drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value > stored to 'idx' during its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/alacritech/slicoss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c > index 15a8096c60df..ac8004186fa8 100644 > --- a/drivers/net/ethernet/alacritech/slicoss.c > +++ b/drivers/net/ethernet/alacritech/slicoss.c > @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev) > { > struct slic_tx_queue *txq = &sdev->txq; > struct net_device *dev = sdev->netdev; > - unsigned int idx = txq->done_idx; > + unsigned int idx; > struct slic_tx_buffer *buff; > unsigned int frames = 0; > unsigned int bytes = 0; You should probably reorder the variables now so they stay longest to shortest.