From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbdJ3MPh (ORCPT ); Mon, 30 Oct 2017 08:15:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26205 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbdJ3MPf (ORCPT ); Mon, 30 Oct 2017 08:15:35 -0400 Date: Mon, 30 Oct 2017 15:15:09 +0300 From: Dan Carpenter To: Ulf Hansson Cc: SF Markus Elfring , "linux-mmc@vger.kernel.org" , Linux USB List , Tony Olech , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode() Message-ID: <20171030121508.zfnsvpsrt25prhr4@mwanda> References: <7b418db1-ec35-4c85-5d06-45edde56822c@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: > On 27 October 2017 at 21:31, SF Markus Elfring > wrote: > > From: Markus Elfring > > Date: Fri, 27 Oct 2017 21:21:40 +0200 > > > > Add a jump target so that a specific string copy operation is stored > > only once at the end of this function implementation. > > Replace two calls of the function "strncpy" by goto statements. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > Thanks, applied for next! > What's the advantage of this patch? The new code seems more complicated to me and GCC automatically reuses duplicate constant strings so there is no memory savings. regards, dan capenter