From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932732AbdJ3RnA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 13:43:00 -0400
Received: from merlin.infradead.org ([205.233.59.134]:36624 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932128AbdJ3Rm7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 13:42:59 -0400
Date: Mon, 30 Oct 2017 18:42:53 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Ingo Molnar <mingo@kernel.org>, Shile Zhang <shile.zhang@nokia.com>,
        linux-kernel@vger.kernel.org,
        Nick Desaulniers <nick.desaulniers@gmail.com>,
        Douglas Anderson <dianders@chromium.org>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations
Message-ID: <20171030174253.d74aowcgetph5vq4@hirez.programming.kicks-ass.net>
References: <20171027234020.26927-1-mka@chromium.org>
 <20171030082612.omuaefugp5nmnnfy@hirez.programming.kicks-ass.net>
 <20171030172710.GE96615@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171030172710.GE96615@google.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 30, 2017 at 10:27:10AM -0700, Matthias Kaehlcke wrote:
> El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit:
> 
> > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote:
> > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate
> > > and sysctl_sched_time_avg includes the attribute const_debug. This
> > > attribute is not part of the extern declaration of these variables in
> > > include/linux/sched/sysctl.h, as a result clang generates warnings like
> > > this:
> > > 
> > >   kernel/sched/sched.h:1618:33: warning: section attribute is specified on
> > >     redeclared variable [-Wsection]
> > >   extern const_debug unsigned int sysctl_sched_time_avg;
> > 
> > Since they're already declared in sched/sysctl.h this redeclaration in
> > sched/sched.h seems pointless.
> 
> We could remove it, but it would require to move the definition of
> const_debug to the 'globally' visible header sched/sysctl.h. Would
> that be your preference? In that case we should probably use a more
> unique name, like const_sched_debug.

Ah, I see; I got lost in the #ifdef maze. Yes you're right. Keep it like
it is then.