mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Wenyou Yang <wenyou.yang@microchip.com>
Cc: kbuild-all@01.org,
	Mauro Carvalho Chehab <mchehab@s-opensource.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	devicetree@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
	Jonathan Corbet <corbet@lwn.net>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-arm-kernel@lists.infradead.org,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Wenyou Yang <wenyou.yang@microchip.com>,
	Songjun Wu <songjun.wu@microchip.com>
Subject: Re: [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver
Date: Mon, 30 Oct 2017 18:02:06 +0800	[thread overview]
Message-ID: <201710301745.IcembUO9%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171027074220.23839-2-wenyou.yang@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

Hi Wenyou,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.14-rc7 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wenyou-Yang/media-i2c-Add-the-ov7740-image-sensor-driver/20171030-140347
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/ov7740.c:57:0: warning: "REG_REG15" redefined
    #define REG_REG15 0x15
    
   In file included from arch/sh/include/asm/ptrace_32.h:4:0,
                    from arch/sh/include/uapi/asm/ptrace.h:30,
                    from arch/sh/include/asm/ptrace.h:13,
                    from include/linux/irq.h:28,
                    from include/linux/gpio/driver.h:6,
                    from include/asm-generic/gpio.h:12,
                    from arch/sh/include/asm/gpio.h:23,
                    from include/linux/gpio.h:48,
                    from drivers/media/i2c/ov7740.c:16:
   arch/sh/include/uapi/asm/ptrace_32.h:20:0: note: this is the location of the previous definition
    #define REG_REG15 15
    
   In file included from drivers/media/i2c/ov7740.c:21:0:
   drivers/media/i2c/ov7740.c: In function 'ov7740_set_ctrl':
   include/linux/regmap.h:73:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
     regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/ov7740.c:512:5: note: 'val' was declared here
     u8 val;
        ^~~

vim +/REG_REG15 +57 drivers/media/i2c/ov7740.c

    55	
    56	#define REG_REG14	0x14
  > 57	#define REG_REG15	0x15
    58	#define REG15_GAIN_MSB	0x03
    59	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 46548 bytes --]

  parent reply	other threads:[~2017-10-30 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  7:42 [PATCH v2 0/2] media: ov7740: Add a V4L2 sensor-level driver Wenyou Yang
2017-10-27  7:42 ` [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver Wenyou Yang
2017-10-30  6:57   ` kbuild test robot
2017-10-30 10:02   ` kbuild test robot [this message]
2017-10-27  7:42 ` [PATCH v2 2/2] media: ov7740: Document device tree bindings Wenyou Yang
2017-10-27 10:59   ` Sakari Ailus
2017-10-30  1:38     ` Yang, Wenyou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201710301745.IcembUO9%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kbuild-all@01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@s-opensource.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=songjun.wu@microchip.com \
    --cc=wenyou.yang@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®