mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Bin Liu <b-liu@ti.com>,
	linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: dsps: remove the duplicated timer
Date: Mon, 30 Oct 2017 22:44:15 +0100	[thread overview]
Message-ID: <20171030214415.GB10043@kroah.com> (raw)
In-Reply-To: <CAGXu5j+12NM6UqVyy7qoqtbxbvbsPSHfTKXgqKJ6dUDapvrLwA@mail.gmail.com>

On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote:
> On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu <b-liu@ti.com> wrote:
> > Now struct musb has the timer (dev_timer) for glue drivers, so let's
> > remove the duplicated timer defined in dsps glue driver, and use
> > dev_timer defined in struct musb.
> >
> > Signed-off-by: Bin Liu <b-liu@ti.com>
> 
> Reviewed-by: Kees Cook <keescook@chromium.org>
> 
> Thanks for this; it wasn't clear to me if both timers needed to exist
> (i.e. glue operated independently from the musb object), so I didn't
> make this change myself.
> 
> Greg, it probably makes sense to just take both patches. Does that work for you?

Yes, I can do that, thanks.

greg k-h

  reply	other threads:[~2017-10-30 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 10:08 [PATCH] usb: musb: Convert timers to use timer_setup() Kees Cook
2017-10-27 16:24 ` Bin Liu
2017-10-30  8:52   ` Greg Kroah-Hartman
2017-10-30 13:17     ` Bin Liu
     [not found]       ` <1509380996-1271-1-git-send-email-b-liu@ti.com>
2017-10-30 21:29         ` [PATCH] usb: musb: dsps: remove the duplicated timer Kees Cook
2017-10-30 21:44           ` Greg Kroah-Hartman [this message]
2017-10-30 16:33     ` [PATCH] usb: musb: Convert timers to use timer_setup() Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171030214415.GB10043@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=b-liu@ti.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome